You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/12 05:45:45 UTC
[GitHub] [incubator-nuttx] pussuw opened a new pull request, #6248: libc: Rename lib_Exit lib__Exit
pussuw opened a new pull request, #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248
Naming collision with lib_exit on some systems
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124554516
@xiaoxiang781216 Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124840623
> > I was thinking that we can rename `lib_exit.c` in this PR, but as you have more context I assume that not. I'm fine with temporary rename
>
> Spec define two api(_exit and _Exit): https://pubs.opengroup.org/onlinepubs/007904875/functions/exit.html we have to keep both.
Yes. But can we place implementation for both `_exit` and `_Exit` in same `lib_exit.c`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124631587
@pussuw Sorry for a dummy question, but can we have a single `lib_exit.c`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124842724
Anyway let's follow a plan and do things step by step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124633220
> @pussuw Sorry for a dummy question, but can we have a single `lib_exit.c`?
Yes, that is the target. This change just renames lib_Exit.c to lib__Exit.c, no extra file is added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124843504
> > > I was thinking that we can rename `lib_exit.c` in this PR, but as you have more context I assume that not. I'm fine with temporary rename
> >
> >
> > Spec define two api(_exit and _Exit): https://pubs.opengroup.org/onlinepubs/007904875/functions/exit.html we have to keep both.
>
> Yes. But can we place implementation for both `_exit` and `_Exit` in same `lib_exit.c`?
No, _Exit() is just a redirection to _exit():
- _exit() is the unistd / posix standard function, lives in unistd.h and its implementation is in the kernel.
- _Exit() is the stdlib version of _exit(). They are literally the same function, but we need to implement both.
Movin _exit() to libc/lib_exit.c is not possible, _exit() is a system call (it lives in the kernel).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124851845
I just was trying to say that `lib_exit.c` vs `lib_Exit.c` only matters on case insensitive file systems, so was thinking that we can rename to lower case and extend it will additional implementation further. But again I'm fine with adding the `_`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124640022
I was thinking that we can rename `lib_exit.c` in this PR, but as you have more context I assume that not. I'm fine with temporary rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124810754
> I was thinking that we can rename `lib_exit.c` in this PR, but as you have more context I assume that not. I'm fine with temporary rename
Spec define two api(_exit and _Exit):
https://pubs.opengroup.org/onlinepubs/007904875/functions/exit.html
we have to keep both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pussuw commented on pull request #6248: libc: Rename lib_Exit lib__Exit
Posted by GitBox <gi...@apache.org>.
pussuw commented on PR #6248:
URL: https://github.com/apache/incubator-nuttx/pull/6248#issuecomment-1124856359
> I just was trying to say that `lib_exit.c` vs `lib_Exit.c` only matters on case insensitive file systems, so was thinking that we can rename to lower case and extend it will additional implementation further. But again I'm fine with adding the `_`.
Yes, that will be the final target. https://github.com/apache/incubator-nuttx/pull/6197/commits/5494d6fe640ee79176186a63379a60d0ff3d2bc4#diff-f6fbc7f42fb5fdcc14dda6a35008d4dca82afa8bcf73f7e8e0df9055e9e0d646
We unfortunately need the intermediate step of renaming, because temporarily there will be libc_exit.c and libc_Exit.c (this will be removed) and like you said, on some systems this causes a naming conflict. This is why I renamed libc_Exit -> libc__Exit.c
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org