You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Martin Kreidenweis (JIRA)" <ji...@apache.org> on 2010/08/06 18:07:22 UTC

[jira] Created: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Customer's Shipment Address Not Assigned to Dropship Purchase Orders
--------------------------------------------------------------------

                 Key: OFBIZ-3883
                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
             Project: OFBiz
          Issue Type: Bug
          Components: order
    Affects Versions: Release Branch 10.04, SVN trunk
         Environment: demo-trunk.ofbiz.apache.org
            Reporter: Martin Kreidenweis


When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 

Steps to Reproduce:
* From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
* Login as admin
* Use the one page checkout to order the products

Resulting Order: 
https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.

Expectation:
All Shipment groups should have the shipping address assigned.

Actual:
Only the first shipment group has the shipping address assigned. 

Possibly offending line of Code: 
ShoppingCart.java line 2235:
        this.setShippingContactMechId(0, shippingContactMechId);
Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux reassigned OFBIZ-3883:
--------------------------------------

    Assignee: Jacques Le Roux

> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898200#action_12898200 ] 

Jacques Le Roux commented on OFBIZ-3883:
----------------------------------------

Martin, Rene,

Quick question: are we waiting a patch here or the changes about would be enough? (sounds like not but just asking while quickly reading)

Thanks

> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Rene Scheibe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896557#action_12896557 ] 

Rene Scheibe edited comment on OFBIZ-3883 at 8/9/10 10:14 AM:
--------------------------------------------------------------

While reproducing it on my local machine, I further found out that some shipping data for the 2nd supplier (DemoSupplier) is missing in table {{order_item_ship_group}} - see below:
||order_id ||ship_group_seq_id ||shipment_method_type_id ||supplier_party_id ||carrier_party_id ||contact_mech_id ||
|LWS10000  |00001              |NO_SHIPPING              |BigSupplier  |_NA_              |10000            |
|LWS10000  |00002              |NULL                     |DemoSupplier  |NULL              |NULL             |



      was (Author: rene.scheibe):
    While reproducing it on my local machine, I further found out that some shipping data for the 2nd supplier is missing in table {{order_item_ship_group}} - see below:
||order_id ||ship_group_seq_id ||shipment_method_type_id ||supplier_party_id ||carrier_party_id ||contact_mech_id ||
|LWS10000  |00001              |NO_SHIPPING              |BigSupplier  |_NA_              |10000            |
|LWS10000  |00002              |NULL                     |DemoSupplier  |NULL              |NULL             |


  
> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Rene Scheibe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896557#action_12896557 ] 

Rene Scheibe commented on OFBIZ-3883:
-------------------------------------

While reproducing it on my local machine, I further found out that some shipping data for the 2nd supplier is missing in table {{order_item_ship_group}} - see below:
||order_id ||ship_group_seq_id ||shipment_method_type_id ||supplier_party_id ||carrier_party_id ||contact_mech_id ||
|LWS10000  |00001              |NO_SHIPPING              |BigSupplier  |_NA_              |10000            |
|LWS10000  |00002              |NULL                     |DemoSupplier  |NULL              |NULL             |



> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux updated OFBIZ-3883:
-----------------------------------

    Comment: was deleted

(was: Martin, Rene,

Quick question: are we waiting a patch here or the changes above would be enough? (sounds like not but just asking while quickly reading)

Thanks)

> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (OFBIZ-3883) Customer's Shipment Address Not Assigned to Dropship Purchase Orders

Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OFBIZ-3883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898200#action_12898200 ] 

Jacques Le Roux edited comment on OFBIZ-3883 at 8/13/10 9:58 AM:
-----------------------------------------------------------------

Martin, Rene,

Quick question: are we waiting a patch here or the changes above would be enough? (sounds like not but just asking while quickly reading)

Thanks

      was (Author: jacques.le.roux):
    Martin, Rene,

Quick question: are we waiting a patch here or the changes about would be enough? (sounds like not but just asking while quickly reading)

Thanks
  
> Customer's Shipment Address Not Assigned to Dropship Purchase Orders
> --------------------------------------------------------------------
>
>                 Key: OFBIZ-3883
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3883
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: Release Branch 10.04, SVN trunk
>         Environment: demo-trunk.ofbiz.apache.org
>            Reporter: Martin Kreidenweis
>            Assignee: Jacques Le Roux
>
> When buying drop ship products from the demo store the customer's shipping address is not saved with the purchase order, so the shipping address cannot be provided to the drop ship supplier. 
> Steps to Reproduce:
> * From the DropShip Category add "DropShip from BigSupplier" and "DropShip from DemoSupplier" to your cart. 
> * Login as admin
> * Use the one page checkout to order the products
> Resulting Order: 
> https://demo-trunk.ofbiz.apache.org:8443/ordermgr/control/orderview?orderId=WSCO10002
> The purchase orders WS10003 and WS10004 are associated correctly with the order items, but as the shipping groups don't have addresses, the purchase orders don't have either.
> Expectation:
> All Shipment groups should have the shipping address assigned.
> Actual:
> Only the first shipment group has the shipping address assigned. 
> Possibly offending line of Code: 
> ShoppingCart.java line 2235:
>         this.setShippingContactMechId(0, shippingContactMechId);
> Should probably not add the contactMechId only to the first CartShipInfo. When we tried to change that, though, drop shipping broke somehow completely. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.