You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/09/17 23:01:49 UTC
[GitHub] [incubator-gobblin] autumnust opened a new pull request #3106: [GOBBLIN-1265] Switch the dependency of gobblin-orc with the shadow jar instead
autumnust opened a new pull request #3106:
URL: https://github.com/apache/incubator-gobblin/pull/3106
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- https://issues.apache.org/jira/browse/GOBBLIN-1265
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
In gobblin-orc's import path, we will need to use the shadowed version from nohive classifier of ORC library to make this work with 1.x internal Hive version.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3106: [GOBBLIN-1265] Switch the dependency of gobblin-orc with the shadow jar instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3106:
URL: https://github.com/apache/incubator-gobblin/pull/3106#issuecomment-694582313
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=h1) Report
> Merging [#3106](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/4d921928b9ca35b81ded594bfa8fc1301c6ff9e7?el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3106 +/- ##
============================================
- Coverage 46.25% 46.24% -0.01%
+ Complexity 9562 9561 -1
============================================
Files 1971 1971
Lines 75310 75310
Branches 8394 8394
============================================
- Hits 34831 34824 -7
- Misses 37197 37203 +6
- Partials 3282 3283 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../gobblin/writer/GenericRecordToOrcValueWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3106/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9HZW5lcmljUmVjb3JkVG9PcmNWYWx1ZVdyaXRlci5qYXZh) | `55.49% <ø> (ø)` | `13.00 <0.00> (ø)` | |
| [...va/org/apache/gobblin/writer/GobblinOrcWriter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3106/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tb3JjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3dyaXRlci9Hb2JibGluT3JjV3JpdGVyLmphdmE=) | `52.74% <ø> (ø)` | `15.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3106/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `34.71% <0.00%> (-5.79%)` | `13.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=footer). Last update [4d92192...713fae1](https://codecov.io/gh/apache/incubator-gobblin/pull/3106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3106: [GOBBLIN-1265] Switch the dependency of gobblin-orc with the shadow jar instead
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3106:
URL: https://github.com/apache/incubator-gobblin/pull/3106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org