You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by SolidWallOfCode <gi...@git.apache.org> on 2017/02/16 15:46:46 UTC
[GitHub] trafficserver pull request #1456: Add TCP accept metric which tracks the tot...
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/1456
Add TCP accept metric which tracks the total number of TCP connections accepted.
`proxy.process.net.tcp.accept`
This is useful to track the rate of inbound connections accepted. This can be compared to transactions, open connections, or other OS network metrics to better identify performance issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SolidWallOfCode/trafficserver yts-502
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1456.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1456
----
commit b96478920bdcc9268d8c43550de4be88ff9d116c
Author: Alan M. Carroll <so...@yahoo-inc.com>
Date: 2017-02-16T15:43:59Z
Add TCP accept metric which tracks the total number of TCP connections accepted.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/128/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1573/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1467/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1456
We should have a metric that tracks the total number of accepts at the TCP layer. I recommend that the name be inline with the current metrics `proxy.process.net.total_accepts`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/138/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/6/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by jacksontj <gi...@git.apache.org>.
Github user jacksontj commented on the issue:
https://github.com/apache/trafficserver/pull/1456
It seems like we should have some sort of layered approach, where we keep track of tcp (l4) http (L5?) and TLS (L7). We have metrics for some of this it sounds, but IIRC they are a bit patchy.
So I'm in favor of a raw "tcp accepted", and IMO the http incoming_connections should probably be 1/2 agnostic (if we want an http_stream_accepted-- we can do that too).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1456
The `http` stat measures only HTTP 1.X connections and only those that are successfully created. If, for example, there is a connection that fails the TLS handshake, this stat will record it but `http.total_incoming_connections` will not. Tunnels will also be tracked by `tcp_accept` and not by the `http` stat.
It also looks like HTTP 2 connections are not tracked by that stat either, which is also distinct. It might be reasonable to either make the existing stat track both or track them independently and sum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Hmmm, how is this different from proxy.process.http.total_incoming_connections ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Yes, if there are subtle differences like this, we should break them out accordingly, and then make an aggregated "sum" metrics in the Lua metrics.config.
It almost sounds like a bug / misfeature that the H2 connection is not included in the proxy.process.http.total_incoming_connections. And it's very inconsistent with other metrics; Whereas these two connection metrics works as you describe (independent), the request metrics are not. E.g.
Sending 4 HTTP/2 request, I see this:
```
./bin/traffic_ctl metric get proxy.process.http2.total_client_streams proxy.process.https.incoming_requests proxy.process.http.incoming_requests
proxy.process.http2.total_client_streams 4
proxy.process.https.incoming_requests 4
proxy.process.http.incoming_requests 4
```
Note how each H2 stream is counted as an HTTPS request, as well as an HTTP request (I'm guessing because of how H2 uses HTTP internally). This seems rather inconsistent to me, but does make some sense I guess
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Why are there tsconfig changes with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1456
http2 connections are tracked by proxy.process.http2.current_client_sessions and proxy.process.http2.total_client_connections.
All successfully negotiated SSL/TCP connections would be the sum of proxy.process.http2.total_client_connections and proxy.process.http.total_client_connections
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1563/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Bad merge, I'll fix the TSConfig stuff.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1457/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---