[jira] [Comment Edited] (AMQ-6108) SelectorManager Executor is not shutdown when transport os stopped.

["Volker Kleinschmidt (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-6108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194293#comment-15194293 ] 

Volker Kleinschmidt edited comment on AMQ-6108 at 3/14/16 10:28 PM:
--------------------------------------------------------------------

Actually these check-ins call setDaemon(false), i.e. they create the ActiveMQ IO Worker thread as user thread, not as daemon. This is exactly the wrong way around, so this issue remains unfixed!


was (Author: volkerk):
Actually these check-ins call setDaemon(false), i.e. they create the ActiveMQ IO Worker thread as user thread, not as daemon. This is exactly the wrong way around!

> SelectorManager Executor is not shutdown when transport os stopped.
> -------------------------------------------------------------------
>
>                 Key: AMQ-6108
>                 URL: https://issues.apache.org/jira/browse/AMQ-6108
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Andy Gumbrecht
>            Assignee: Timothy Bish
>             Fix For: 5.13.1, 5.14.0
>
>         Attachments: SelectorManager.Shutdown.patch
>
>
> SelectorManager creates an Executor that is not shut down on termination of the Transport.
> The Executor currently uses non-daemon threads and is is not guaranteed the the SelectorWorker thread exit condition is ever met.
> This causes the shutdown to hang when using transports that utilise the SelectorManager, such as nio+ssl for example.
> The proposed patch shuts down the ExecutorService on/after Transport shutdown. The SelectorWorkers also check for this as an exit condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)