You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ab...@apache.org on 2025/06/19 13:17:17 UTC

(hive) branch master updated: HIVE-28874 Incorrect comparison in LlapFixedRegistryImpl (#5742)

This is an automated email from the ASF dual-hosted git repository.

abstractdog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hive.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c69f10f14b HIVE-28874 Incorrect comparison in LlapFixedRegistryImpl (#5742)
0c69f10f14b is described below

commit 0c69f10f14b0f4b1983093de105ed6b35d4d483b
Author: Dmitry Kryukov <dk...@users.noreply.github.com>
AuthorDate: Thu Jun 19 16:17:09 2025 +0300

    HIVE-28874 Incorrect comparison in LlapFixedRegistryImpl (#5742)
---
 .../apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java b/llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
index b78c15ec344..cfd3f39c95d 100644
--- a/llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
+++ b/llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
@@ -257,7 +257,7 @@ public List<LlapServiceInstance> getAllInstancesOrdered(boolean consistentIndexe
       Collections.sort(list, new Comparator<LlapServiceInstance>() {
         @Override
         public int compare(LlapServiceInstance o1, LlapServiceInstance o2) {
-          return o2.getWorkerIdentity().compareTo(o2.getWorkerIdentity());
+          return o1.getWorkerIdentity().compareTo(o2.getWorkerIdentity());
         }
       });
       return list;