You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by PhilCai1993 <gi...@git.apache.org> on 2018/04/19 05:38:44 UTC
[GitHub] incubator-weex pull request #1119: [WEEX-297][iOS] fix iOS 11 save image per...
GitHub user PhilCai1993 opened a pull request:
https://github.com/apache/incubator-weex/pull/1119
[WEEX-297][iOS] fix iOS 11 save image permission
From iOS 11, NSPhotoLibraryAddUsageDescription is required in info.plist to save image to album.
Bug [297](https://issues.apache.org/jira/browse/WEEX-297)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PhilCai1993/incubator-weex infoplist
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1119.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1119
----
commit 337b95e01b8a552a82c172a38f15453f00d2bfa9
Author: Phil <zh...@...>
Date: 2018-04-19T05:36:18Z
[WEEX-297][iOS] fix iOS 11 save image permission
----
---
[GitHub] incubator-weex issue #1119: [WEEX-297][iOS] fix iOS 11 save image permission
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1119
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #1119: [WEEX-297][iOS] fix iOS 11 save image per...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1119
---
[GitHub] incubator-weex issue #1119: [WEEX-297][iOS] fix iOS 11 save image permission
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1119
I attach some
documentation about the key
https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CocoaKeys.html#//apple_ref/doc/uid/TP40009251-SW73
---
[GitHub] incubator-weex issue #1119: [WEEX-297][iOS] fix iOS 11 save image permission
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1119
@PhilCai1993 thanks for your contribution , it will be accepted.
---
[GitHub] incubator-weex issue #1119: [WEEX-297][iOS] fix iOS 11 save image permission
Posted by PhilCai1993 <gi...@git.apache.org>.
Github user PhilCai1993 commented on the issue:
https://github.com/apache/incubator-weex/pull/1119
rebased @acton393
---
[GitHub] incubator-weex issue #1119: [WEEX-297][iOS] fix iOS 11 save image permission
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1119
hi thanks for your carefully finding the bug @PhilCai1993
you can rebase your branch to this repository master branch or just check out a new branch based on the master branch, I see another old change on this pull request.
---