[jira] [Updated] (CASSANDRA-21199) ProtocolVersion::supportedVersions can be computed once to avoid showing up in allocation profiles

["Matt Byrd (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-21199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Byrd updated CASSANDRA-21199:
----------------------------------
    Attachment: CASSANDRA-21394_mbyrd_trunk_ci_summary.html

> ProtocolVersion::supportedVersions can be computed once to avoid showing up in allocation profiles
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21199
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21199
>             Project: Apache Cassandra
>          Issue Type: Improvement
>            Reporter: Matt Byrd
>            Assignee: Matt Byrd
>            Priority: Normal
>         Attachments: CASSANDRA-21394_mbyrd_trunk_ci_summary.html, Screenshot 2026-03-04 at 7.01.51 PM.png
>
>
> It's a relatively small amount in one allocation profile (see attached screenshot) ~0.3% of allocations, but still seems un-necessary as we're copying elements from a static final EnumSet
> {code}
>     /** All supported versions, published as an enumset */
>     public final static EnumSet<ProtocolVersion> SUPPORTED = EnumSet.copyOf(Arrays.asList(ArrayUtils.addAll(SUPPORTED_VERSIONS)));
> {code}
> Could instead just compute this in static initialization .
> {code}
>     public static List<String> supportedVersions()
>     {
>         List<String> ret = new ArrayList<>(SUPPORTED.size());
>         for (ProtocolVersion version : SUPPORTED)
>             ret.add(version.toString());
>         return ret;
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org