You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "wuwen5 (via GitHub)" <gi...@apache.org> on 2024/01/03 09:33:55 UTC
[PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
wuwen5 opened a new pull request, #6234:
URL: https://github.com/apache/incubator-seata/pull/6234
resolve transitive dependencies for the `druid`
<!-- Please make sure you have read and understood the contributing guidelines -->
- [ ] I have registered the PR [changes](../changes).
### Ⅰ. Describe what this PR did
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440244844
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
`seata-sqlparser-druid`中的`druid`依赖也是`provided`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440247402
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
https://github.com/apache/incubator-seata/blob/6011c68f58b9bdc5d14f259b39ea49572c9c6f32/sqlparser/seata-sqlparser-druid/pom.xml#L42-L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440242706
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
seata强依赖druid sqlparser做sql的解析，你为什么要将其scope改为provided，如果你有依赖冲突，应该解决你的依赖冲突问题，而不是提pr到社区粗暴的解决
Seata strong dependency druid sqlparser does sql parsing, why do you want to change its scope to provided, if you have dependency conflicts, you should solve your dependency conflicts instead of mentioning pr to the community for rough resolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 closed pull request #6234: optimize:resolve transitive dependencies for the `druid`
URL: https://github.com/apache/incubator-seata/pull/6234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "wuwen5 (via GitHub)" <gi...@apache.org>.
wuwen5 commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440247402
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
https://github.com/apache/incubator-seata/blob/6011c68f58b9bdc5d14f259b39ea49572c9c6f32/sqlparser/seata-sqlparser-druid/pom.xml#L39-L43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440274989
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
Because seata-all strong dependency, it is allowed to provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] optimize:resolve transitive dependencies for the `druid` [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#issuecomment-1875122619
https://github.com/apache/incubator-seata/blob/2.x/sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/DefaultDruidLoader.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org