You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "huaxiang sun (JIRA)" <ji...@apache.org> on 2016/12/03 22:05:59 UTC
[jira] [Created] (HBASE-17249) Get/Scan's
setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as
the parameter instead of creating a new setColumnFamilyTimeRange instance
huaxiang sun created HBASE-17249:
------------------------------------
Summary: Get/Scan's setTimeRange/setColumnFamilyTimeRange can take the TimeRange reference as the parameter instead of creating a new setColumnFamilyTimeRange instance
Key: HBASE-17249
URL: https://issues.apache.org/jira/browse/HBASE-17249
Project: HBase
Issue Type: Bug
Affects Versions: 2.0.0
Reporter: huaxiang sun
Assignee: huaxiang sun
Priority: Minor
Going through the code, found For Get/Scan's setTimeRange/setColumnFamilyTimeRange, it can the TimeRange as reference instead of creating a new one, most of the cases, make just-created TimeRange garbage collected.
Reference:
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L500
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L506
We can implement this in a similar way as filter:
https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java#L510
I checked it is same with branch-1.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)