[GitHub] [geode] echobravopapa opened pull request #4846: GEODE-7908: Throws IllegalArgumentException if client config uses SNI…

["echobravopapa (GitHub)" <gi...@apache.org>]

… without SSL enabled.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4846 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pivotal-jbarrett commented on pull request #4846: GEODE-7908: Throws IllegalArgumentException if client config uses SNI…

["pivotal-jbarrett (GitHub)" <gi...@apache.org>]

I am really not keen on using `Properties` configure proxies. How does the user know which arbitrary `Properties` object to pass? A strongly typed value expresses the correct value without support documentation. Also are we saying that the user is responsible for passing the configuration rather than the system passing it on the `createSocket` method or some lifecycle method?

(Javadocs are missing) 

[ Full content available at: https://github.com/apache/geode/pull/4846 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org