You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@cocoon.apache.org by re...@apache.org on 2006/02/12 15:13:22 UTC

svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer: cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-plugin/src/m...

Author: reinhard
Date: Sun Feb 12 06:13:21 2006
New Revision: 377178

URL: http://svn.apache.org/viewcvs?rev=377178&view=rev
Log:
COCOON-1759 -  RAD works now for resources - thanks to Daniel's latest changes to block-fw. After integrating the reloading classloader into the blocks-fw we have everything we want :-)

Modified:
    cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22.java
    cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22Test.java
    cocoon/trunk/cocoon-block-deployer/cocoon-deployer-plugin/src/main/java/org/apache/cocoon/maven/deployer/SingleBlockDeployMojo.java

Modified: cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22.java?rev=377178&r1=377177&r2=377178&view=diff
==============================================================================
--- cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22.java (original)
+++ cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22.java Sun Feb 12 06:13:21 2006
@@ -134,7 +134,7 @@
 						String nextDirectory = intDirToStringDirConvert(
 								getNextDirectory(new File(baseDirectoryFile, BLOCKS_DIR), this.lastDir));
 						this.lastDir = Integer.parseInt(nextDirectory);
-						String installDirectory = BLOCKS_DIR + nextDirectory;
+						String installDirectory = BLOCKS_DIR + nextDirectory + "/";
 						wiringBlock.setLocation(installDirectory);					
 						deployBlock(binaryBlock, frm, txId, BLOCKS_DIR + nextDirectory);
 						installedBlocks.put(block.getId(), installDirectory);

Modified: cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22Test.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22Test.java?rev=377178&r1=377177&r2=377178&view=diff
==============================================================================
--- cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22Test.java (original)
+++ cocoon/trunk/cocoon-block-deployer/cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/CocoonServer22Test.java Sun Feb 12 06:13:21 2006
@@ -82,9 +82,9 @@
 		assertEquals("db", wiring.getBlock(1).getId());
 		
 		// check locations
-		assertEquals("/blocks/00000001", wiring.getBlock(0).getLocation());
-		assertEquals("/blocks/00000002", wiring.getBlock(1).getLocation());
-		assertEquals("/blocks/00000002", wiring.getBlock(2).getLocation()); // ensure that a block is unpacked only once
+		assertEquals("/blocks/00000001/", wiring.getBlock(0).getLocation());
+		assertEquals("/blocks/00000002/", wiring.getBlock(1).getLocation());
+		assertEquals("/blocks/00000002/", wiring.getBlock(2).getLocation()); // ensure that a block is unpacked only once
 		
 		// check connections
 		assertEquals("db", wiring.getBlock(0).getConnections().getConnection(0).getName());

Modified: cocoon/trunk/cocoon-block-deployer/cocoon-deployer-plugin/src/main/java/org/apache/cocoon/maven/deployer/SingleBlockDeployMojo.java
URL: http://svn.apache.org/viewcvs/cocoon/trunk/cocoon-block-deployer/cocoon-deployer-plugin/src/main/java/org/apache/cocoon/maven/deployer/SingleBlockDeployMojo.java?rev=377178&r1=377177&r2=377178&view=diff
==============================================================================
--- cocoon/trunk/cocoon-block-deployer/cocoon-deployer-plugin/src/main/java/org/apache/cocoon/maven/deployer/SingleBlockDeployMojo.java (original)
+++ cocoon/trunk/cocoon-block-deployer/cocoon-deployer-plugin/src/main/java/org/apache/cocoon/maven/deployer/SingleBlockDeployMojo.java Sun Feb 12 06:13:21 2006
@@ -141,7 +141,7 @@
         block.setUrn(urn);
         // needs to be commented out as long as the blocks-fw supports directories outside
         // of the servlet context
-//        block.setLocation("target/classes");
+        block.setLocation("target/classes");
                 
         // create the deployment object
         Deploy deploy = new Deploy();



Re: RAD with blocks

Posted by Giacomo Pati <gi...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 13 Feb 2006, Reinhard Poetz wrote:

> Date: Mon, 13 Feb 2006 13:44:12 +0100
> From: Reinhard Poetz <re...@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: RAD with blocks
> 
> Giacomo Pati wrote:
>
>> >  Basically I agree with you but as soon as the ReloadingClassloader is 
>> >  integrated I don't see a reason not to use it at development time which 
>> >  makes auto-compilation mandatory. I'm an Eclipse user, but don't support 
>> >  IDEA and Netbeans auto-compilation either?
>>
>>
>>  Well, from a users POV an XML, XSLT, sitemap file is a totally different
>>  thing than a class file (which he obviously knows to be compiled first
>>  before being usable).
>
> I'd say that we should wait for user feedback on this. The thing is that I 
> hesitate to make too many things configureable, but sure, if configurations 
> are required, we can add them.
>
> Currently cocoon:simple-deploy points to ./target/classes. We can make this 
> configureable so that people can point to ./src/java/resources. The only 
> thing that I really want to avoid is the possibility to set two locations for 
> a block, one for the compiled Java classes and one for the resources (smells 
> like FS ...).

No, it's not FS. It's not for distributable artifacts and not for life 
deployment, Just for development.

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD8IKhLNdJvZjjVZARAh7lAKCM4ilDgrrEP66Y32Nm4Kt2ZcX6vQCgr2cr
Cxpl3NcnSbM/zBIeDPJPbzc=
=7YaH
-----END PGP SIGNATURE-----

Re: RAD with blocks

Posted by Reinhard Poetz <re...@apache.org>.
Giacomo Pati wrote:

>> Basically I agree with you but as soon as the ReloadingClassloader is 
>> integrated I don't see a reason not to use it at development time 
>> which makes auto-compilation mandatory. I'm an Eclipse user, but don't 
>> support IDEA and Netbeans auto-compilation either?
> 
> 
> Well, from a users POV an XML, XSLT, sitemap file is a totally different 
> thing than a class file (which he obviously knows to be compiled first 
> before being usable).

I'd say that we should wait for user feedback on this. The thing is that I 
hesitate to make too many things configureable, but sure, if configurations are 
required, we can add them.

Currently cocoon:simple-deploy points to ./target/classes. We can make this 
configureable so that people can point to ./src/java/resources. The only thing 
that I really want to avoid is the possibility to set two locations for a block, 
one for the compiled Java classes and one for the resources (smells like FS ...).

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

	

	
		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

Re: RAD with blocks

Posted by Giacomo Pati <gi...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 13 Feb 2006, Reinhard Poetz wrote:

> Date: Mon, 13 Feb 2006 12:17:26 +0100
> From: Reinhard Poetz <re...@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: RAD with blocks
> 
> Giacomo Pati wrote:
>
>>  Just to let you know.
>>
>>  I was corrected by Reinhart.
>
> Reinhard
>        ^ ;-)

Oops, I'm so sorry (one should write names by heart)

>
>>  The RAD works with the
>>  cocoon-trunk/cocoon-block-deployer/cocoon-deployer-plugin-demo module (and
>>  not the one I was using for my tests as mentioned above). Also one needs
>>  to have Eclipse auto-build enabled so that changed resources will be
>>  copied over to the target directory (which isn't that pretty IMHO but
>>  maybe this can be fixed anyhow as Eclipse isn't the only IDE used in the
>>  world ;-)
>
> Basically I agree with you but as soon as the ReloadingClassloader is 
> integrated I don't see a reason not to use it at development time which makes 
> auto-compilation mandatory. I'm an Eclipse user, but don't support IDEA and 
> Netbeans auto-compilation either?

Well, from a users POV an XML, XSLT, sitemap file is a totally different 
thing than a class file (which he obviously knows to be compiled first 
before being usable).

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD8G15LNdJvZjjVZARArneAJ4+5VT3T6EEtx8rEv3R7A1UVKVSxACgz0wV
mTx5Q5A6lkdihRALGh+aCfk=
=DXj3
-----END PGP SIGNATURE-----

Re: RAD with blocks

Posted by Daniel Fagerstrom <da...@nada.kth.se>.
Reinhard Poetz wrote:
> Giacomo Pati wrote:
>
>> Just to let you know.
>>
>> I was corrected by Reinhart.
>
> Reinhard
>        ^ ;-)
>
>> The RAD works with the 
>> cocoon-trunk/cocoon-block-deployer/cocoon-deployer-plugin-demo module 
>> (and not the one I was using for my tests as mentioned above). Also 
>> one needs to have Eclipse auto-build enabled so that changed 
>> resources will be copied over to the target directory (which isn't 
>> that pretty IMHO but maybe this can be fixed anyhow as Eclipse isn't 
>> the only IDE used in the world ;-)
>
> Basically I agree with you but as soon as the ReloadingClassloader is 
> integrated I don't see a reason not to use it at development time 
> which makes auto-compilation mandatory. I'm an Eclipse user, but don't 
> support IDEA and Netbeans auto-compilation either?
>
> BTW, if somebody is interested in working on making blocks reality and 
> is looking for a manageable task, he can do the integration of the 
> ReloadingClassloader into the blocks-fw. If so, just let me know (so 
> that we don't duplicate our efforts).
>
RT: When we move to OSGi the Cocoon "platform" will contain the same 
basic standard OSGi framework and service bundles as Eclipse (or maybe 
from Felix). And a Cocoon block will basically be a bundle, and such can 
be developed with the plug-in development environment in Eclipse. Maybe 
Eclipse auto build is gathered in a few plug-ins, in that case we could 
just reuse them for Cocoon development. Anyone who knows how it works in 
Eclipse?

/Daniel


RAD with blocks

Posted by Reinhard Poetz <re...@apache.org>.
Giacomo Pati wrote:

> Just to let you know.
> 
> I was corrected by Reinhart.

Reinhard
        ^ ;-)

> The RAD works with the 
> cocoon-trunk/cocoon-block-deployer/cocoon-deployer-plugin-demo module 
> (and not the one I was using for my tests as mentioned above). Also one 
> needs to have Eclipse auto-build enabled so that changed resources will 
> be copied over to the target directory (which isn't that pretty IMHO but 
> maybe this can be fixed anyhow as Eclipse isn't the only IDE used in the 
> world ;-)

Basically I agree with you but as soon as the ReloadingClassloader is integrated 
I don't see a reason not to use it at development time which makes 
auto-compilation mandatory. I'm an Eclipse user, but don't support IDEA and 
Netbeans auto-compilation either?

BTW, if somebody is interested in working on making blocks reality and is 
looking for a manageable task, he can do the integration of the 
ReloadingClassloader into the blocks-fw. If so, just let me know (so that we 
don't duplicate our efforts).

-- 
Reinhard Pötz           Independent Consultant, Trainer & (IT)-Coach 

{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                        web(log): http://www.poetz.cc
--------------------------------------------------------------------

	

	
		
___________________________________________________________ 
Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

Re: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer: cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-plugin/src/m...

Posted by Giacomo Pati <gi...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon, 13 Feb 2006, Giacomo Pati wrote:

> Date: Mon, 13 Feb 2006 11:05:09 +0100 (CET)
> From: Giacomo Pati <gi...@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer:
>     cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applications
>     erver/
>     cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applications
>     erver/ cocoon-deployer-plugin/src/m...
> 
> --[PinePGP]--------------------------------------------------[begin]--
>
> I've used the
>
> cocoon-trunk/cocoon-block-deployer/cocoon-tutorial-simple-block
>
> to be precise

Just to let you know.

I was corrected by Reinhart.

The RAD works with the 
cocoon-trunk/cocoon-block-deployer/cocoon-deployer-plugin-demo module 
(and not the one I was using for my tests as mentioned above). Also one 
needs to have Eclipse auto-build enabled so that changed resources will 
be copied over to the target directory (which isn't that pretty IMHO but 
maybe this can be fixed anyhow as Eclipse isn't the only IDE used in the 
world ;-)

Thanks and ciao

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD8GMjLNdJvZjjVZARAnjMAKDtn1xRnaVx6xujEAMIHMzhqcTHjgCglPGc
eZoo1JHWPJDh0eJKNu4WxBM=
=ilEo
-----END PGP SIGNATURE-----

Re: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer: cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-plugin/src/m...

Posted by Giacomo Pati <gi...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


I've used the

cocoon-trunk/cocoon-block-deployer/cocoon-tutorial-simple-block

to be precise

On Mon, 13 Feb 2006, Giacomo Pati wrote:

> Date: Mon, 13 Feb 2006 11:02:20 +0100 (CET)
> From: Giacomo Pati <gi...@apache.org>
> Reply-To: dev@cocoon.apache.org
> To: dev@cocoon.apache.org
> Subject: Re: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer:
>     cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applications
>     erver/
>     cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applications
>     erver/ cocoon-deployer-plugin/src/m...
> 
> --[PinePGP]--------------------------------------------------[begin]--
> On Sun, 12 Feb 2006, reinhard@apache.org wrote:
>
>>  Date: Sun, 12 Feb 2006 14:13:22 -0000
>>  From: reinhard@apache.org
>>  Reply-To: dev@cocoon.apache.org
>>  To: cvs@cocoon.apache.org
>>  Subject: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer:
>>      cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applications
>>      erver/
>>      cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applications
>>      erver/ cocoon-deployer-plugin/src/m...
>>
>>  Author: reinhard
>>  Date: Sun Feb 12 06:13:21 2006
>>  New Revision: 377178
>>
>>  URL: http://svn.apache.org/viewcvs?rev=377178&view=rev
>>  Log:
>>  COCOON-1759 -  RAD works now for resources - thanks to Daniel's latest
>>  changes to block-fw. After integrating the reloading classloader into the
>>  blocks-fw we have everything we want :-)
>
> Can you explain this? I've tried to build and run with
>
>   mvn cocoon:simple-deploy jetty6:run
>
> which worked so far hit the browser on http://localhost:8888/test which
> works as well but changing the test.xml under src/main/resources didn't
> show any effects.
>
> TIA
>
> --
> Giacomo Pati
> Otego AG, Switzerland - http://www.otego.com
> Orixo, the XML business alliance - http://www.orixo.com
> --[PinePGP]-----------------------------------------------------------
> gpg:  Signature made Mon Feb 13 11:02:21 2006 CET using DSA key ID 98E35590
> gpg:  Good signature from "Giacomo Pati <gi...@otego.com>"
> gpg:                  aka "Giacomo Pati <gi...@apache.org>"
> gpg:                  aka "Giacomo Pati <gi...@pati.ch>"
> --[PinePGP]----------------------------------------------------[end]--
>

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD8FnWLNdJvZjjVZARAsncAJ9GXtN72FYnt9WIyx45nm2VlB8DvwCgy788
2WFZh/lj7rxYDhWVYIzTyTw=
=X+QN
-----END PGP SIGNATURE-----

Re: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer: cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applicationserver/ cocoon-deployer-plugin/src/m...

Posted by Giacomo Pati <gi...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sun, 12 Feb 2006, reinhard@apache.org wrote:

> Date: Sun, 12 Feb 2006 14:13:22 -0000
> From: reinhard@apache.org
> Reply-To: dev@cocoon.apache.org
> To: cvs@cocoon.apache.org
> Subject: svn commit: r377178 - in /cocoon/trunk/cocoon-block-deployer:
>     cocoon-deployer-core/src/main/java/org/apache/cocoon/deployer/applications
>     erver/
>     cocoon-deployer-core/src/test/java/org/apache/cocoon/deployer/applications
>     erver/ cocoon-deployer-plugin/src/m...
> 
> Author: reinhard
> Date: Sun Feb 12 06:13:21 2006
> New Revision: 377178
>
> URL: http://svn.apache.org/viewcvs?rev=377178&view=rev
> Log:
> COCOON-1759 -  RAD works now for resources - thanks to Daniel's latest changes to block-fw. After integrating the reloading classloader into the blocks-fw we have everything we want :-)

Can you explain this? I've tried to build and run with

    mvn cocoon:simple-deploy jetty6:run

which worked so far hit the browser on http://localhost:8888/test which 
works as well but changing the test.xml under src/main/resources didn't 
show any effects.

TIA

- -- 
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD8FktLNdJvZjjVZARAkhlAKCZwJe+lu29Htne/nv6q7bMh2ArFgCgo7ZV
YkCgO8QLwfrp32sUt+/PXSM=
=ifoa
-----END PGP SIGNATURE-----