You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/07/23 19:18:41 UTC
[GitHub] couchdb-fauxton pull request: Port from apache/couchdb: COUCHDB-21...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/15
Port from apache/couchdb: COUCHDB-2158 Fauxton: Implement a filter for changes
This is a port from https://github.com/apache/couchdb/pull/227 - full previous discussion there.
There are already changes from the previous review included, and after the review I will rebase/squash them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/couchdb-fauxton 2158-changes-filter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/15.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15
----
commit 8ff72f889bf9a07fd7a49568dd426978ab2769aa
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-08T19:26:36Z
Fauxton: Implement a filter for changes
As code is duplicated, mode the filter to the component. Tthe filter
then can be overwritten if there anything special is needed.
commit 263d328dace3756a5bec0eb59a241ba6e8187898
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-16T18:44:15Z
review
commit cf9114d3035173f930e1a39ecae3ef68e5acab42
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:31:07Z
rename js-log-filter-form to js-filter-form
commit 5ca3f3cb288a59726ce14e9ff842c3a2fc3ee0e5
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:32:41Z
remove sidebar filter, add header filter
commit f53e55b1652c462c46d94f2147089cf04621e0dd
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:36:09Z
make filtering case insensitive
commit 477debe42247f887da36d4f0ec3251a9c2f4805c
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:40:14Z
use strong tag instead of a h6, change button to primary button color (red)
commit b254d84c4d8a6ebc26efdf9c10b6924ff1656254
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:43:42Z
change <%= to <%- as <%= is not needed
commit 65a4a3fbd9090344a50bc2898367586e3fcd459e
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T13:44:38Z
we can add tooltips to a filter
commit 1275ec6d6b87f323b1ad92b5861b3c7abcb21feb
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T14:33:12Z
make deleted documents searchable
they are missing an explicit deleted flag
commit b1121dbb95bac358a4f9a8c39fbd11f42ca294db
Author: Robert Kowalski <ro...@kowalski.gd>
Date: 2014-05-29T15:01:29Z
add license header
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Port from apache/couchdb: COUCHDB-21...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Port from apache/couchdb: COUCHDB-21...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/15#issuecomment-49941055
I am getting a 1262 LOC conflict now :( - will have to rebuild that when I have time and use this as a base.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---