You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/09/01 00:13:06 UTC
[kudu-CR] [tablet] Add tablet metric for number of rowsets
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11378
Change subject: [tablet] Add tablet metric for number of rowsets
......................................................................
[tablet] Add tablet metric for number of rowsets
Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11378/1
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11378
to look at the new patch set (#4).
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
[tablet] Add tablet metric for number of diskrowsets
Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 26 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11378/4
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 18:16:33 +0000
Gerrit-HasComments: No
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11378
to look at the new patch set (#2).
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
[tablet] Add tablet metric for number of diskrowsets
Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11378/2
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [tablet] Add tablet metric for number of rowsets
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of rowsets
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc@173
PS1, Line 173: Rowsets
this is specifically rowsets on disk, right? does it include MRS?
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 01 Sep 2018 00:17:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2257
PS3, Line 2257: // Take a ref to components to avoid a TOCTOU error.
Is that necessary with component_lock_ held just above?
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2259
PS3, Line 2259: return components ? components->rowsets->all_rowsets().size() : 0;
So the old implementation could dereference null here?
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 04 Sep 2018 17:47:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/11378/1/src/kudu/tablet/tablet.cc@173
PS1, Line 173: mber of
> this is specifically rowsets on disk, right? does it include MRS?
Right, just diskrowsets. I'll update the name and description.
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc
File src/kudu/tablet/tablet.cc:
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2257
PS3, Line 2257: }
> Is that necessary with component_lock_ held just above?
Done
http://gerrit.cloudera.org:8080/#/c/11378/3/src/kudu/tablet/tablet.cc@2259
PS3, Line 2259: void Tablet::PrintRSLayout(ostream* o) {
> So the old implementation could dereference null here?
Yes. If metrics are gathered before the tablet is opened, as tested by TestMetricsInit in tablet-test.
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 04 Sep 2018 18:00:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11378 )
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
[tablet] Add tablet metric for number of diskrowsets
Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Reviewed-on: http://gerrit.cloudera.org:8080/11378
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 26 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tablet] Add tablet metric for number of diskrowsets
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11378
to look at the new patch set (#3).
Change subject: [tablet] Add tablet metric for number of diskrowsets
......................................................................
[tablet] Add tablet metric for number of diskrowsets
Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
---
M src/kudu/tablet/tablet.cc
M src/kudu/tserver/tablet_server-test.cc
2 files changed, 29 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/11378/3
--
To view, visit http://gerrit.cloudera.org:8080/11378
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb1ca202c281da07007eff1f555af2eef9b2393e
Gerrit-Change-Number: 11378
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>