You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/18 05:32:44 UTC

[GitHub] john-bodley commented on a change in pull request #6857: auto-set 'Is Temporal' to true where column_name == '__time'

john-bodley commented on a change in pull request #6857: auto-set 'Is Temporal' to true where column_name == '__time'
URL: https://github.com/apache/incubator-superset/pull/6857#discussion_r257561861
 
 

 ##########
 File path: superset/connectors/base/models.py
 ##########
 @@ -28,6 +28,10 @@
 from superset.utils import core as utils
 
 
+# If the column_name is one of these, is_dttm is set to True
+TIME_COLUMN_NAMES = ['__time']
 
 Review comment:
   @mistercrunch any reason this isn’t part of `db_engine_specs.py`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org