You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/02/04 00:20:14 UTC
Review Request 17680: Break down free slots stats into dedicated and shared.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-152
https://issues.apache.org/jira/browse/AURORA-152
Repository: aurora
Description
-------
Break down free slots stats into dedicated and shared.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6
Diff: https://reviews.apache.org/r/17680/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 17680: Break down free slots stats into dedicated and
shared.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680/
-----------------------------------------------------------
(Updated Feb. 4, 2014, 6:44 p.m.)
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-152
https://issues.apache.org/jira/browse/AURORA-152
Repository: aurora
Description
-------
Break down free slots stats into dedicated and shared.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6
Diff: https://reviews.apache.org/r/17680/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner
Re: Review Request 17680: Break down free slots stats into dedicated and
shared.
Posted by Bill Farner <wf...@apache.org>.
> On Feb. 4, 2014, 4:20 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java, line 61
> > <https://reviews.apache.org/r/17680/diff/1/?file=463692#file463692line61>
> >
> > Is it public only because of MachineResourceProvider interface?
It's exposed for that reason, but you're right that it should be package private. Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680/#review33594
-----------------------------------------------------------
On Feb. 3, 2014, 11:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17680/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 11:20 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-152
> https://issues.apache.org/jira/browse/AURORA-152
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Break down free slots stats into dedicated and shared.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6
>
> Diff: https://reviews.apache.org/r/17680/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17680: Break down free slots stats into dedicated and
shared.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680/#review33594
-----------------------------------------------------------
Ship it!
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java
<https://reviews.apache.org/r/17680/#comment63130>
Is it public only because of MachineResourceProvider interface?
- Maxim Khutornenko
On Feb. 3, 2014, 11:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17680/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 11:20 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-152
> https://issues.apache.org/jira/browse/AURORA-152
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Break down free slots stats into dedicated and shared.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee
> src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee
> src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069
> src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6
>
> Diff: https://reviews.apache.org/r/17680/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 17680: Break down free slots stats into dedicated and
shared.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17680/
-----------------------------------------------------------
(Updated Feb. 3, 2014, 11:20 p.m.)
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-152
https://issues.apache.org/jira/browse/AURORA-152
Repository: aurora
Description
-------
Break down free slots stats into dedicated and shared.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/base/Conversions.java c77ec421d313daeca21ef978a05349527fcb7dee
src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 460e7f7965e2756cd8d8be886a900ec8adc880ee
src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 4f6775fc57139a29ef16256e4c578cf5f1c40069
src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java f2473929f501559c4f5e366d96c05fa22597bfe6
Diff: https://reviews.apache.org/r/17680/diff/
Testing
-------
./gradlew build
Thanks,
Bill Farner