You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/01 09:19:50 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#5035: Enhance type enum valueOf in mysql protocol.
KomachiSion opened a new pull request #5035: Enhance type enum valueOf in mysql protocol.
URL: https://github.com/apache/incubator-shardingsphere/pull/5035
During parsing binlog protocol, `MySQLBinlogEventType.valueOf` will be called for each binlog to determine the type of binlog.
The old implementation, is O(n) time complexity, which will have a little impact on performance for many binlog events.
The problem for `MySQLColumnType.valueOf`, each row-based event include column types for each column. So there are many times to call this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5035:
Enhance type enum valueOf in mysql protocol.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5035: Enhance type enum valueOf in mysql protocol.
URL: https://github.com/apache/incubator-shardingsphere/pull/5035
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#5035: Enhance type enum valueOf in mysql protocol.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5035: Enhance type enum valueOf in mysql protocol.
URL: https://github.com/apache/incubator-shardingsphere/pull/5035#issuecomment-607150434
## Pull Request Test Coverage Report for [Build 2316](https://coveralls.io/builds/29764369)
* **11** of **11** **(100.0%)** changed or added relevant lines in **2** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.09%**) to **57.266%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29764369/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29764369) |
| :-- | --: |
| Change from base [Build 10764](https://coveralls.io/builds/29759718): | 0.09% |
| Covered Lines: | 11688 |
| Relevant Lines: | 20410 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5035:
Enhance type enum valueOf in mysql protocol.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5035: Enhance type enum valueOf in mysql protocol.
URL: https://github.com/apache/incubator-shardingsphere/pull/5035#issuecomment-607150434
## Pull Request Test Coverage Report for [Build 10766](https://coveralls.io/builds/29764313)
* **11** of **11** **(100.0%)** changed or added relevant lines in **2** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.01%**) to **57.188%**
---
| Totals | [](https://coveralls.io/builds/29764313) |
| :-- | --: |
| Change from base [Build 10764](https://coveralls.io/builds/29759718): | 0.01% |
| Covered Lines: | 11672 |
| Relevant Lines: | 20410 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5035:
Enhance type enum valueOf in mysql protocol.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5035: Enhance type enum valueOf in mysql protocol.
URL: https://github.com/apache/incubator-shardingsphere/pull/5035#issuecomment-607146940
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=h1) Report
> Merging [#5035](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/04c89cd5c2b9f5be33d67e0b80612163c25324fc&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `90.90%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5035 +/- ##
============================================
+ Coverage 53.81% 53.82% +0.01%
Complexity 394 394
============================================
Files 1146 1146
Lines 20405 20410 +5
Branches 3703 3703
============================================
+ Hits 10980 10985 +5
Misses 8751 8751
Partials 674 674
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../protocol/mysql/constant/MySQLBinlogEventType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQmlubG9nRXZlbnRUeXBlLmphdmE=) | `95.45% <83.33%> (+0.33%)` | `0.00 <0.00> (ø)` | |
| [...abase/protocol/mysql/constant/MySQLColumnType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ29sdW1uVHlwZS5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=footer). Last update [04c89cd...6f7dbca](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services