You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2012/02/15 16:20:59 UTC
[jira] [Created] (CASSANDRA-3915) Fix LazilyCompactedRowTest
Fix LazilyCompactedRowTest
--------------------------
Key: CASSANDRA-3915
URL: https://issues.apache.org/jira/browse/CASSANDRA-3915
Project: Cassandra
Issue Type: Bug
Components: Tests
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Minor
LazilyCompactedRowTest.testTwoRowSuperColumn has never really worked. It uses LazilyCompactedRowTest.assertBytes() that assumes standard columns, even though that test is for super columns. For some reason, the deserialization of the super columns as columns was not breaking stuff and so the test was "working", but CASSANDRA-3872 changed that and LazilyCompactedRowTest.testTwoRowSuperColumn fails on current cassandra-1.1 branch (but it's not CASSANDRA-3872 fault, just the test that is buggy).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3915) Fix LazilyCompactedRowTest
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3915:
----------------------------------------
Attachment: 3915.patch
Attached patch to fix the tests. I believe the patch apply cleanly to both 1.0 (for which the test don't fail but is still broken) and 1.1 (where it does fix the test failure).
> Fix LazilyCompactedRowTest
> --------------------------
>
> Key: CASSANDRA-3915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3915
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.0.8, 1.1.0
>
> Attachments: 3915.patch
>
>
> LazilyCompactedRowTest.testTwoRowSuperColumn has never really worked. It uses LazilyCompactedRowTest.assertBytes() that assumes standard columns, even though that test is for super columns. For some reason, the deserialization of the super columns as columns was not breaking stuff and so the test was "working", but CASSANDRA-3872 changed that and LazilyCompactedRowTest.testTwoRowSuperColumn fails on current cassandra-1.1 branch (but it's not CASSANDRA-3872 fault, just the test that is buggy).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3915) Fix LazilyCompactedRowTest
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208543#comment-13208543 ]
Brandon Williams commented on CASSANDRA-3915:
---------------------------------------------
+1
> Fix LazilyCompactedRowTest
> --------------------------
>
> Key: CASSANDRA-3915
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3915
> Project: Cassandra
> Issue Type: Bug
> Components: Tests
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.0.8, 1.1.0
>
> Attachments: 3915.patch
>
>
> LazilyCompactedRowTest.testTwoRowSuperColumn has never really worked. It uses LazilyCompactedRowTest.assertBytes() that assumes standard columns, even though that test is for super columns. For some reason, the deserialization of the super columns as columns was not breaking stuff and so the test was "working", but CASSANDRA-3872 changed that and LazilyCompactedRowTest.testTwoRowSuperColumn fails on current cassandra-1.1 branch (but it's not CASSANDRA-3872 fault, just the test that is buggy).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira