[GitHub] [hive] deniskuzZ commented on a diff in pull request #3652: HIVE-26614: Fix adding custom jars in Job Classpath.

[GitBox <gi...@apache.org>]

deniskuzZ commented on code in PR #3652:
URL: https://github.com/apache/hive/pull/3652#discussion_r991035653


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -4158,7 +4158,7 @@ public static void addDependencyJars(Configuration conf, Class<?>... classes)
       if (!localFs.exists(new Path(path))) {
         throw new RuntimeException("Could not validate jar file " + path + " for class " + clazz);
       }
-      jars.add(path);
+      jars.add(localFs.makeQualified(new Path(path)).toString());

Review Comment:
   should we use the FileUtils helper method?
   ````
   FileUtils.makeQualified(path, conf).toString()
   ````



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org