[GitHub] [hadoop] cnauroth commented on pull request #4409: HDFS-16623. Avoid IllegalArgumentException in LifelineSender

[GitBox <gi...@apache.org>]

cnauroth commented on PR #4409:
URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1149161121

   @ZanderXu , yes, I was thinking of just testing that `getLifelineWaitTime()` only returns non-negative numbers. There is a similar kind of test in `TestBpServiceActorScheduler#testScheduleLifeline`, but it doesn't yet cover the case that would lead to a negative value.
   
   I think testing for LifelineSender thread exit would be more complete, but also a lot more complex. Testing directly against the `getLifelineWaitTime()` return values is a good compromise.
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org