You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "xy2953396112 (via GitHub)" <gi...@apache.org> on 2025/08/16 23:41:02 UTC
[PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
xy2953396112 opened a new pull request, #3422:
URL: https://github.com/apache/celeborn/pull/3422
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Remove redundant PartitionType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3422: [CELEBORN-2108] Remove redundant PartitionType
URL: https://github.com/apache/celeborn/pull/3422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3422:
URL: https://github.com/apache/celeborn/pull/3422#issuecomment-3199799025
Merged to main(v0.7.0) and branch-0.6(v0.6.1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on PR #3422:
URL: https://github.com/apache/celeborn/pull/3422#issuecomment-3199743022
> Thanks for contribution. I left some comments for this.
Thanks for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3422:
URL: https://github.com/apache/celeborn/pull/3422#discussion_r2284495876
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -90,11 +89,9 @@ public PartitionDataWriter(
writerContext.setPartitionDataWriter(this);
writerContext.setDeviceMonitor(deviceMonitor);
- this.partitionType = partitionType;
+ this.partitionType = writerContext.getPartitionType();
Review Comment:
Remove this variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2108] Remove redundant PartitionType [celeborn]
Posted by "xy2953396112 (via GitHub)" <gi...@apache.org>.
xy2953396112 commented on code in PR #3422:
URL: https://github.com/apache/celeborn/pull/3422#discussion_r2284508377
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java:
##########
@@ -90,11 +89,9 @@ public PartitionDataWriter(
writerContext.setPartitionDataWriter(this);
writerContext.setDeviceMonitor(deviceMonitor);
- this.partitionType = partitionType;
+ this.partitionType = writerContext.getPartitionType();
Review Comment:
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org