You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2023/03/02 10:41:03 UTC
[GitHub] [incubator-celeborn] waitinfuture opened a new pull request, #1301: [CELEBORN-372] Remove the standard Apache License header from the top…
waitinfuture opened a new pull request, #1301:
URL: https://github.com/apache/incubator-celeborn/pull/1301
… of third-party source files
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
This PR aims to remove the standard Apache License header from the top of third-party source files.
According to LICENSE file, I found two files.
- https://github.com/apache/spark/blob/master/LICENSE
### Why are the changes needed?
This was discussed via general@incubator mailing list when releasing Celeborn
- https://lists.apache.org/thread/q8hchs4n2twhjl0qf3rn0ln0hyrvrnnp
and discussed in dev@spark
- https://lists.apache.org/thread/wfy9sykncw2znhzlvyd18bkyjr7l9x43
Here is the ASF legal policy.
- https://www.apache.org/legal/src-headers.html#3party
> Do not add the standard Apache License header to the top of third-party source files.
### Does this PR introduce _any_ user-facing change?
No. This is a source code distribution.
### How was this patch tested?
Manual review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 merged pull request #1301: [CELEBORN-372] Remove the standard Apache License header from the top of third-party source files
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #1301:
URL: https://github.com/apache/incubator-celeborn/pull/1301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1301: [CELEBORN-372] Remove the standard Apache License header from the top of third-party source files
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1301:
URL: https://github.com/apache/incubator-celeborn/pull/1301#issuecomment-1451692130
Thanks, merged to main/0.2(https://github.com/apache/incubator-celeborn/pull/1302)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1301: [CELEBORN-372] Remove the standard Apache License header from the top…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1301:
URL: https://github.com/apache/incubator-celeborn/pull/1301#issuecomment-1451670832
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1301?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1301](https://codecov.io/gh/apache/incubator-celeborn/pull/1301?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (615a5e2) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/dcedf7b0a9c23566b5dfb53fafa131e01b5d3624?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcedf7b) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1301 +/- ##
============================================
- Coverage 27.80% 27.78% -0.01%
+ Complexity 842 840 -2
============================================
Files 219 219
Lines 18607 18607
Branches 2002 2002
============================================
- Hits 5171 5168 -3
- Misses 13077 13079 +2
- Partials 359 360 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...leborn/common/network/util/LimitedInputStream.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay91dGlsL0xpbWl0ZWRJbnB1dFN0cmVhbS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `76.58% <0.00%> (-1.35%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org