You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "karan singh malhi (JIRA)" <ji...@apache.org> on 2007/06/03 22:36:15 UTC

[jira] Created: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
-----------------------------------------------------------------------------------------

                 Key: OPENEJB-590
                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
             Project: OpenEJB
          Issue Type: Bug
         Environment: win xp sp2
            Reporter: karan singh malhi


mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
    <fileSet>
      <directory>target/classes/</directory>
      <outputDirectory>bin/</outputDirectory>

The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by Mohammad Nour El-Din <no...@gmail.com>.
Yes you are right. I will review your patch and apply it.

On 6/3/07, karan singh malhi (JIRA) <ji...@apache.org> wrote:
>
>
>     [
> https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> karan singh malhi updated OPENEJB-590:
> --------------------------------------
>
>    Attachment: OPENEJB-590.patch
>
> Fixed this issue.
> The files to be copied to the bin folder were available in
> openejb-standalone/src/main/resources.
> Changed openejb-standalone/src/main/assembly/bin to point to the resources
> folder instead of ${basedir}/target/classes
>
> > mvn -Dassemble does not create bin directory in the assembly of module
> openejb-standalone
> >
> -----------------------------------------------------------------------------------------
> >
> >                 Key: OPENEJB-590
> >                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
> >             Project: OpenEJB
> >          Issue Type: Bug
> >         Environment: win xp sp2
> >            Reporter: karan singh malhi
> >         Attachments: OPENEJB-590.patch
> >
> >
> > mvn -Dassemble does not create bin directory in the assembly of module
> openejb-standalone. This is because of the following in
> assembly/openejb-standalone/src/main/assembly/bin.xml.
> >     <fileSet>
> >       <directory>target/classes/</directory>
> >       <outputDirectory>bin/</outputDirectory>
> > The problem is that when the above is executed by Maven, it finds that
> there are no files in target/classes, so it skips copying anything from this
> folder to the bin folder. Since, it skips the copying, it never creates the
> bin folder.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>


-- 
Thanks
- Mohammad Nour

[jira] Updated: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

karan singh malhi updated OPENEJB-590:
--------------------------------------

    Attachment: openejb-590-1.patch

The earlier patch did not copy the openejb file to the bin directory. It also did not clean up the target/classes and target/archive-tmp directories which are just required temporarily by the assembly to do filtering and copy filtered resources. Added the antrun plugin to do the clean up in the package phase

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>    Affects Versions: 3.0
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>             Fix For: 3.0
>
>         Attachments: openejb-590-1.patch, OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501764 ] 

Mohammad Nour commented on OPENEJB-590:
---------------------------------------

Applied
-------------------------------------------------------------------------------------------------- 
Sending        assembly/openejb-standalone/src/main/assembly/bin.xml
Transmitting file data .
Committed revision 544704.

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: Mohammad Nour
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501761 ] 

Mohammad Nour commented on OPENEJB-590:
---------------------------------------

RTC

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: Mohammad Nour
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammad Nour reassigned OPENEJB-590:
-------------------------------------

    Assignee: karan singh malhi  (was: Mohammad Nour)

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammad Nour updated OPENEJB-590:
----------------------------------

        Fix Version/s: 3.0
    Affects Version/s: 3.0

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>    Affects Versions: 3.0
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>             Fix For: 3.0
>
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammad Nour reassigned OPENEJB-590:
-------------------------------------

    Assignee: Mohammad Nour  (was: karan singh malhi)

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: Mohammad Nour
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "karan singh malhi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

karan singh malhi updated OPENEJB-590:
--------------------------------------

    Attachment: OPENEJB-590.patch

Fixed this issue. 
The files to be copied to the bin folder were available in openejb-standalone/src/main/resources. 
Changed openejb-standalone/src/main/assembly/bin to point to the resources folder instead of ${basedir}/target/classes

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (OPENEJB-590) mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone

Posted by "Mohammad Nour (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OPENEJB-590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mohammad Nour reassigned OPENEJB-590:
-------------------------------------

    Assignee: karan singh malhi

> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone
> -----------------------------------------------------------------------------------------
>
>                 Key: OPENEJB-590
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-590
>             Project: OpenEJB
>          Issue Type: Bug
>         Environment: win xp sp2
>            Reporter: karan singh malhi
>            Assignee: karan singh malhi
>         Attachments: OPENEJB-590.patch
>
>
> mvn -Dassemble does not create bin directory in the assembly of module openejb-standalone. This is because of the following in assembly/openejb-standalone/src/main/assembly/bin.xml.
>     <fileSet>
>       <directory>target/classes/</directory>
>       <outputDirectory>bin/</outputDirectory>
> The problem is that when the above is executed by Maven, it finds that there are no files in target/classes, so it skips copying anything from this folder to the bin folder. Since, it skips the copying, it never creates the bin folder. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.