You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/08/05 11:33:15 UTC

[jira] Created: (FELIX-2521) Method call failures not always handled correctly

Method call failures not always handled correctly
-------------------------------------------------

                 Key: FELIX-2521
                 URL: https://issues.apache.org/jira/browse/FELIX-2521
             Project: Felix
          Issue Type: Bug
          Components: Declarative Services (SCR), Specification compliance
    Affects Versions:  scr-1.4.0
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For:  scr-1.4.2


Our current Declarative Services implementation abstracts calling declared methods by the BaseMethod.invoke method. This method returns a boolean which is true, iff the method was declared and present and calling it succeeded. False is returned otherwise.

This is problematic in some circumstances, where call failure is ignored but absence of the method is interesting. This is namely the case for the modified method which must be called if delclared and present but success or failure should just be logged, but further be ignored. If the method is not present, the old configuration update way of deactivating and reactivating the method must be chosen.

The current implementation will reactivate the component also when the modified method call failed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2521) Method call failures not always handled correctly

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed FELIX-2521.
------------------------------------


Apache Felix Declarative Services 1.6.0 has been released. The issues are now closed.

> Method call failures not always handled correctly
> -------------------------------------------------
>
>                 Key: FELIX-2521
>                 URL: https://issues.apache.org/jira/browse/FELIX-2521
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR), Specification compliance
>    Affects Versions:  scr-1.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For:  scr-1.6.0
>
>
> Our current Declarative Services implementation abstracts calling declared methods by the BaseMethod.invoke method. This method returns a boolean which is true, iff the method was declared and present and calling it succeeded. False is returned otherwise.
> This is problematic in some circumstances, where call failure is ignored but absence of the method is interesting. This is namely the case for the modified method which must be called if delclared and present but success or failure should just be logged, but further be ignored. If the method is not present, the old configuration update way of deactivating and reactivating the method must be chosen.
> The current implementation will reactivate the component also when the modified method call failed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2521) Method call failures not always handled correctly

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-2521.
--------------------------------------

    Resolution: Fixed

Fixed in Rev. 982605. Support separation between "no method to be called" and "method execution failure" situations to handle according specification:
  - activate method failure is logged and must cause activation failure
  - deactivate method failure is just logged
  - modified method failure is just logged
  - bind method failure is just logged
  - unbind method failure is just logged

Callers of the BaseMethod.invoke method now indicates, whether a failure executing the method should be an invocation failure or just be logged but then assumed to be ok.

> Method call failures not always handled correctly
> -------------------------------------------------
>
>                 Key: FELIX-2521
>                 URL: https://issues.apache.org/jira/browse/FELIX-2521
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR), Specification compliance
>    Affects Versions:  scr-1.4.0
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For:  scr-1.4.2
>
>
> Our current Declarative Services implementation abstracts calling declared methods by the BaseMethod.invoke method. This method returns a boolean which is true, iff the method was declared and present and calling it succeeded. False is returned otherwise.
> This is problematic in some circumstances, where call failure is ignored but absence of the method is interesting. This is namely the case for the modified method which must be called if delclared and present but success or failure should just be logged, but further be ignored. If the method is not present, the old configuration update way of deactivating and reactivating the method must be chosen.
> The current implementation will reactivate the component also when the modified method call failed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.