You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/12/18 08:29:16 UTC
[I] bug: ManifestList parsing should not require `partition_type`. [iceberg-rust]
liurenjie1024 opened a new issue, #121:
URL: https://github.com/apache/iceberg-rust/issues/121
In [manifest list parser](https://github.com/apache/iceberg-rust/blob/82e129945bed150b6d9fbcb93ebb4d92f8150895/crates/iceberg/src/spec/manifest_list.rs#L57), we ask user to pass in a `partition_type`. This is incorrect since different manifest file may have different partition spec, so we should ask user to pass a `HashMap<i32, StructType>`, e.g. a mapping from partition spec id to partition type. See https://iceberg.apache.org/spec/#snapshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: ManifestList parsing should not require `partition_type`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #121:
URL: https://github.com/apache/iceberg-rust/issues/121#issuecomment-1859772664
cc @ZENOTME
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: ManifestList parsing should not require `partition_type`. [iceberg-rust]
Posted by "ZENOTME (via GitHub)" <gi...@apache.org>.
ZENOTME commented on issue #121:
URL: https://github.com/apache/iceberg-rust/issues/121#issuecomment-1859832146
Thanks! I will send a PR to fix it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] bug: ManifestList parsing should not require `partition_type`. [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko closed issue #121: bug: ManifestList parsing should not require `partition_type`.
URL: https://github.com/apache/iceberg-rust/issues/121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org