You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shai Erera (JIRA)" <ji...@apache.org> on 2010/02/27 22:39:05 UTC
[jira] Created: (LUCENE-2289) Calls to SegmentInfos.message should
be wrapped w/ infoStream != null checks
Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
----------------------------------------------------------------------------
Key: LUCENE-2289
URL: https://issues.apache.org/jira/browse/LUCENE-2289
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Shai Erera
Fix For: 3.1
To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Assigned: (LUCENE-2289) Calls to SegmentInfos.message should
be wrapped w/ infoStream != null checks
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless reassigned LUCENE-2289:
------------------------------------------
Assignee: Michael McCandless
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2289) Calls to SegmentInfos.message should
be wrapped w/ infoStream != null checks
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shai Erera updated LUCENE-2289:
-------------------------------
Attachment: LUCENE--2289.patch
Patch w/ the proposed changes.
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2289) Calls to SegmentInfos.message should
be wrapped w/ infoStream != null checks
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-2289.
----------------------------------------
Resolution: Fixed
Thanks Shai!
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message
should be wrapped w/ infoStream != null checks
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839445#action_12839445 ]
Shai Erera commented on LUCENE-2289:
------------------------------------
Are you talking about this: if (exc != null && infoStream != null) {
It used to be
{code}
if (exc != null) {
message();
}
{code}
And I changed it to
{code}
if (exc != null && infoStream != null) {
message();
}
{code}
Or is it something else?
Anyway according to the patch it's on rev. 917047?
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message
should be wrapped w/ infoStream != null checks
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839441#action_12839441 ]
Shai Erera commented on LUCENE-2289:
------------------------------------
Can someone plz help me commit this? The change is really simple.
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message
should be wrapped w/ infoStream != null checks
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839447#action_12839447 ]
Michael McCandless commented on LUCENE-2289:
--------------------------------------------
Woops sorry my bad -- I just wasn't up to date. T'sall good... I'll commit shortly.
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message
should be wrapped w/ infoStream != null checks
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839451#action_12839451 ]
Shai Erera commented on LUCENE-2289:
------------------------------------
Phew .. I was wondering if using words like 'trivial' and 'simple' in issues jinxes them :)
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2289) Calls to SegmentInfos.message
should be wrapped w/ infoStream != null checks
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839442#action_12839442 ]
Michael McCandless commented on LUCENE-2289:
--------------------------------------------
Shai, which version did you generate the patch on? I hit one odd hunk failure in applying the patch to trunk, because your version doesn't have an "if (exc != null)" check...
> Calls to SegmentInfos.message should be wrapped w/ infoStream != null checks
> ----------------------------------------------------------------------------
>
> Key: LUCENE-2289
> URL: https://issues.apache.org/jira/browse/LUCENE-2289
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Fix For: 3.1
>
> Attachments: LUCENE--2289.patch
>
>
> To avoid the expensive message creation (which involves the '+' operator on strings, calls to message should be wrapped w/ infoStream != null check, rather than inside message(). I'll attach a patch which does that.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org