You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Mohamed Battisha <mb...@yahoo.com> on 2011/11/21 23:21:49 UTC

Review Request: testCoordChangeEndTime and testCoordChangeXCommand are failing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2903/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

testCoordChangeEndTime and testCoordChangeXCommand are failing


This addresses bug OOZIE-608.
    https://issues.apache.org/jira/browse/OOZIE-608


Diffs
-----

  http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1204714 
  http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1204714 

Diff: https://reviews.apache.org/r/2903/diff


Testing
-------


Thanks,

Mohamed

Re: Review Request: testCoordChangeEndTime and testCoordChangeXCommand are failing

Posted by Mohamed Battisha <mb...@yahoo.com>.

Thanks Angelo
will add more comments and submit another patch

BTW: throughout the DateUtils.Java, the 'ss' is not used, so if you add the 'ss' to the date format it will cause the test to fail. I changed the comments to reflect this fact and to reduce the confusion 

Thanks!
Mohamed

    


On Nov 21, 2011, at 8:51 PM, Angelo K. Huang wrote:

> This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2903/
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java (Diff revision 2)
> public static Timestamp convertDateToTimestamp(Date d) {
> 267	
>      * 
> space
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java (Diff revision 2)
> public static Timestamp convertDateToTimestamp(Date d) {
> 271	
>         SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm'Z'");
> where is ss? yyyy-MM-ddTHH:mm:ssZ
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java (Diff revision 2)
> protected void tearDown() throws Exception {
> 70	
>         String pauseTime = DateUtils.convertDateToString(new Date().getTime() + 10 * 60 * 1000);
> could you add comment here to show how do you get pausetime and endtime?
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java (Diff revision 2)
> public void testCoordChangeXCommand() throws StoreException, CommandException {
> 231	
>         String pauseTime = DateUtils.convertDateToString(startTime.getTime() + 10 * 60 * 1000);
> same thing there
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java (Diff revision 2)
> public void testCoordChangeXCommand() throws StoreException, CommandException {
> 244	
>      *
> 254	
>      * 
> space
> 
> - Angelo K.
> 
> 
> On November 21st, 2011, 10:21 p.m., Mohamed Battisha wrote:
> 
> Review request for oozie.
> By Mohamed Battisha.
> Updated 2011-11-21 22:21:49
> 
> Description
> 
> testCoordChangeEndTime and testCoordChangeXCommand are failing
> Bugs: OOZIE-608
> Diffs
> 
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java (1204714)
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java (1204714)
> View Diff
>

Re: Review Request: testCoordChangeEndTime and testCoordChangeXCommand are failing

Posted by "Angelo K. Huang" <an...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2903/#review3424
-----------------------------------------------------------



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java
<https://reviews.apache.org/r/2903/#comment7668>

    space



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java
<https://reviews.apache.org/r/2903/#comment7669>

    where is ss? yyyy-MM-ddTHH:mm:ssZ



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/2903/#comment7665>

    could you add comment here to show how do you get pausetime and endtime?



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/2903/#comment7666>

    same thing there



http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
<https://reviews.apache.org/r/2903/#comment7667>

    space


- Angelo K.


On 2011-11-21 22:21:49, Mohamed Battisha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2903/
> -----------------------------------------------------------
> 
> (Updated 2011-11-21 22:21:49)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> testCoordChangeEndTime and testCoordChangeXCommand are failing
> 
> 
> This addresses bug OOZIE-608.
>     https://issues.apache.org/jira/browse/OOZIE-608
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/DateUtils.java 1204714 
>   http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1204714 
> 
> Diff: https://reviews.apache.org/r/2903/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mohamed
> 
>