You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/03 23:46:00 UTC

[GitHub] [airflow] KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports

KevinYang21 commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r320522177
 
 

 ##########
 File path: airflow/_vendor/nvd3/__init__.py
 ##########
 @@ -16,14 +16,14 @@
            'scatterChart', 'discreteBarChart', 'multiBarChart']
 
 
+from . import ipynb
+from .cumulativeLineChart import cumulativeLineChart
 
 Review comment:
   Will exclude unnecessary packages. Given how automatic isort can be esp. with pre-commit, I prefer to roll the change out in one commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services