You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/23 12:07:50 UTC
[GitHub] [dubbo-go] relaxedCat opened a new pull request #627: fix issue #616 fix gitee sonar code check
relaxedCat opened a new pull request #627:
URL: https://github.com/apache/dubbo-go/pull/627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #627: fix issue #616 fix gitee sonar code check
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #627:
URL: https://github.com/apache/dubbo-go/pull/627#discussion_r444182433
##########
File path: common/rpc_service.go
##########
@@ -68,7 +68,7 @@ var (
typeOfError = reflect.TypeOf((*error)(nil)).Elem()
// ServiceMap store description of service.
- // todo: lowerecas?
+ // TODO
Review comment:
todo miss `lowercas`, you can delete it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #627: fix: fix gitee sonar code check(issue #616)
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #627:
URL: https://github.com/apache/dubbo-go/pull/627
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org