[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5079: vxlan: Fix failure to delete vxlan

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5079:
URL: https://github.com/apache/cloudstack/pull/5079#discussion_r647414707



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java
##########
@@ -376,7 +376,9 @@ private void deleteVnetBr(String brName, boolean deleteBr) {
             command.add("-v", vNetId);
             command.add("-p", pName);
             command.add("-b", brName);
-            command.add("-d", String.valueOf(deleteBr));
+            if (cmdout != null && !cmdout.contains("vxlan")) {

Review comment:
       @Pearl1594 to be consistent with line 368, should it be the following here ?
   ```
   if (cmdout == null || ! cmdout.contains("vxlan")) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org