[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6648: Added Adafruit QT Py RP2040 board and made UART, SPI, and I2C configuration more flexible.

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6648:
URL: https://github.com/apache/incubator-nuttx/pull/6648#discussion_r926663557


##########
arch/arm/src/rp2040/Kconfig:
##########
@@ -13,9 +20,63 @@ config RP2040_UART0
 
 if RP2040_UART0
 
+config RP2040_UART0_TX_GPIO

Review Comment:
   Usually peripheral driver options are out of peripheral selection menu. For example if I select `SPI0` peripheral for the "arch" I need to go to another menu to select polling vs DMA or enable other arch SPI options.
   The pins are the board level configuration and not the "arch" level configuration and usually are defined in board level header file. I understand that for the boards that have many pins exposed to connectors it is reasonable to have configuration options for those pins, but I think that grouping pin configuration at board level makes more sense. At least if config of all pins are on the same screen the visual check may be done to inspect if there are not duplicates.
   So my opinion is to have such config at board level 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org