You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/12/01 18:30:07 UTC
Review Request 64252: Convert resource format of messages entering
master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64252/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Convert resource format of messages entering master.
Diffs
-----
src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e
src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41
Diff: https://reviews.apache.org/r/64252/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64252: Convert resource format of messages entering
master.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64252/#review192901
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 4, 2017, 3:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64252/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2017, 3:27 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Convert resource format of messages entering master.
>
>
> Diffs
> -----
>
> src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
> src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41
>
>
> Diff: https://reviews.apache.org/r/64252/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 64252: Convert resource format of messages entering
master.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64252/
-----------------------------------------------------------
(Updated Dec. 4, 2017, 3:27 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Convert resource format of messages entering master.
Diffs (updated)
-----
src/master/master.cpp 883793a226849434eb833c3027d121635a86fdc4
src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41
Diff: https://reviews.apache.org/r/64252/diff/2/
Changes: https://reviews.apache.org/r/64252/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 64252: Convert resource format of messages entering
master.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64252/#review192529
-----------------------------------------------------------
Fix it, then Ship it!
src/master/master.cpp
Lines 6048 (patched)
<https://reviews.apache.org/r/64252/#comment270731>
s/format/format./
TODO for moving this stuff (and for task and executor resources) including validation into the installer handler.
src/master/master.cpp
Lines 6375 (patched)
<https://reviews.apache.org/r/64252/#comment270732>
ditto. see above.
- Vinod Kone
On Dec. 1, 2017, 6:30 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64252/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2017, 6:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Convert resource format of messages entering master.
>
>
> Diffs
> -----
>
> src/master/master.cpp dfe60ef670edcaefa0c1241df2e2870f650fcf9e
> src/master/registry_operations.cpp 1e1eadb539482113e8ca8cb0542e5aaf34a38b41
>
>
> Diff: https://reviews.apache.org/r/64252/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>