[GitHub] [ozone] xBis7 commented on a diff in pull request #3750: HDDS-7217. OM logs wrong bucket layout

[GitBox <gi...@apache.org>]

xBis7 commented on code in PR #3750:
URL: https://github.com/apache/ozone/pull/3750#discussion_r971335688


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -632,6 +632,10 @@ public void createBucket(
     StorageType storageType = bucketArgs.getStorageType() == null ?
         StorageType.DEFAULT : bucketArgs.getStorageType();
     BucketLayout bucketLayout = bucketArgs.getBucketLayout();
+    if (bucketLayout == null) {
+      bucketLayout = BucketLayout
+          .fromString(conf.get(OMConfigKeys.OZONE_DEFAULT_BUCKET_LAYOUT));

Review Comment:
   @sadanand48 Thanks for reviewing this PR. It seems safe to me. The logs are reading the bucket layout from the client and the client in return reads it from the command args. I don't see another approach to this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org