[GitHub] [arrow] cyb70289 commented on a change in pull request #7285: ARROW-8843: [C++] Compare bitmaps in words

[GitBox <gi...@apache.org>]

cyb70289 commented on a change in pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#discussion_r433019772



##########
File path: cpp/src/arrow/util/bit_util.cc
##########
@@ -246,6 +246,49 @@ bool BitmapEquals(const uint8_t* left, int64_t left_offset, const uint8_t* right
   }
 
   // Unaligned slow case
+  left += left_offset / 8;
+  right += right_offset / 8;
+  left_offset %= 8;
+  right_offset %= 8;
+
+  // process in 64 bits
+  int64_t nwords = bit_length / 64;

Review comment:
       Thank you. Will change.
   A quick question, is there formal doc for arrow C++ coding style?
   I see class names are camel case.
   Most variables are snake case, with [some exceptions](https://github.com/apache/arrow/blob/f0ed8e2343569047204c5c1a0a24e379c0d23c30/cpp/src/arrow/util/bit_util.h#L890).
   Most function names are camel case, with [some exceptions](https://github.com/apache/arrow/blob/f0ed8e2343569047204c5c1a0a24e379c0d23c30/cpp/src/arrow/util/bit_util.h#L503)(simple getter should be snake case?)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org