You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/14 07:26:57 UTC

[kudu-CR] [docs] add guide to symbolize stack addresses 

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15728


Change subject: [docs] add guide to symbolize stack addresses
......................................................................

[docs] add guide to symbolize stack addresses

Change-Id: I299768a49cc52324482c410064bb590393499689
---
M docs/troubleshooting.adoc
1 file changed, 65 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15728/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 20:22:58 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 1: Code-Review+1

Thanks for adding this guide, Alexey!


-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 19:23:50 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Grant Henke, Greg Solovyev, Bankim Bhavsar, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15728

to look at the new patch set (#2).

Change subject: [docs] add guide to symbolize stack addresses
......................................................................

[docs] add guide to symbolize stack addresses

Change-Id: I299768a49cc52324482c410064bb590393499689
---
M docs/troubleshooting.adoc
1 file changed, 67 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15728/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 18 Apr 2020 18:52:06 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15728/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/15728/1/docs/troubleshooting.adoc@1041
PS1, Line 1041: (in this example, it's `kudu-master`). If the binary is stripped of symbols
> I don't think you need a line break before "("
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 19:39:32 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15728/1/docs/troubleshooting.adoc
File docs/troubleshooting.adoc:

http://gerrit.cloudera.org:8080/#/c/15728/1/docs/troubleshooting.adoc@1041
PS1, Line 1041: (in this example, it's `kudu-master`). If the binary is stripped of symbols
I don't think you need a line break before "("



-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 18:14:27 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................


Patch Set 2:

> Thanks for adding this guide, Alexey!

Thank you for the review!


-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 21:55:46 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] add guide to symbolize stack addresses

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15728 )

Change subject: [docs] add guide to symbolize stack addresses
......................................................................

[docs] add guide to symbolize stack addresses

Change-Id: I299768a49cc52324482c410064bb590393499689
Reviewed-on: http://gerrit.cloudera.org:8080/15728
Tested-by: Kudu Jenkins
Reviewed-by: Greg Solovyev <gs...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M docs/troubleshooting.adoc
1 file changed, 67 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Greg Solovyev: Looks good to me, but someone else must approve
  Grant Henke: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/15728
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I299768a49cc52324482c410064bb590393499689
Gerrit-Change-Number: 15728
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)