You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/06/29 21:31:44 UTC
[GitHub] [mynewt-core] ncasaril opened a new pull request #2637: hw/ipc_nrf5340: (Re-)Fix enabling GPIO passing to network core
ncasaril opened a new pull request #2637:
URL: https://github.com/apache/mynewt-core/pull/2637
The outcome of #2629 used a bitmask to set which GPIOs the application core handed over to the networking core.
This made for neat code but complicated the syscfg handling.
This PR undoes #2629, the bitmask change, and uses preprocessor magic to accomplish the same with a simple comma separated syscfg value for specifying pins.
Feedback welcome again, and this time I'll hang out for consensus before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2637: hw/ipc_nrf5340: (Re-)Fix enabling GPIO passing to network core
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2637:
URL: https://github.com/apache/mynewt-core/pull/2637#issuecomment-870936582
I am fine with both approaches, the macro approach preferred. Thank you for pushing this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] sjanc merged pull request #2637: hw/ipc_nrf5340: (Re-)Fix enabling GPIO passing to network core
Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #2637:
URL: https://github.com/apache/mynewt-core/pull/2637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org