You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 15:31:08 UTC

[GitHub] [arrow-rs] crepererum commented on a change in pull request #307: ensure null-counts are written for all-null columns

crepererum commented on a change in pull request #307:
URL: https://github.com/apache/arrow-rs/pull/307#discussion_r633636791



##########
File path: parquet/src/arrow/arrow_writer.rs
##########
@@ -1560,4 +1560,21 @@ mod tests {
             panic!("Statistics::Int64 missing")
         }
     }
+
+    #[test]

Review comment:
       I am not entirely happy with this test since it requires an arrow data structure to actually test an parquet-part. It would probably be nice to have a more "pure" test as well, however I wasn't able to formulate an easy one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org