[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #761: DISPATCH-1657: DISPATCH-1545: check for un-initialized router connect…

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #761:
URL: https://github.com/apache/qpid-dispatch/pull/761#discussion_r442294031



##########
File path: src/router_core/forwarder.c
##########
@@ -660,23 +660,25 @@ int qdr_forward_closest_CT(qdr_core_t      *core,
                 qd_bitmask_first_set(addr->closest_remotes, &addr->next_remote);
 
             // get the inter-router connection associated with path to rnode:
-            int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
-            qdr_link_t *out_link;
-            if (control) {
-                out_link = peer_router_control_link(core, conn_bit);
-            } else if (!receive_complete) {
-                out_link = get_outgoing_streaming_link(core, core->rnode_conns_by_mask_bit[conn_bit]);
-            } else {
-                out_link = peer_router_data_link(core, conn_bit, qdr_forward_effective_priority(msg, addr));
-            }
+            const int conn_bit = (rnode->next_hop) ? rnode->next_hop->conn_mask_bit : rnode->conn_mask_bit;
+            if (conn_bit >= 0) {

Review comment:
       Yeah I checked each access to node->conn_mask_bit and use of the conn bit in that file and elsewhere.  I'm pretty sure I've covered all the bases.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org