You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Andrea Del Bene <an...@gmail.com> on 2017/01/17 08:52:10 UTC

Re: [jira] [Updated] (WICKET-6306) Changing model object of Panel added to a Border not allowed

Hi Martin,

should I remove version '8.0.0' from 'Fix version'?

Andrea.


On 16/01/2017 22:03, Martin Grigorov (JIRA) wrote:
>       [ https://issues.apache.org/jira/browse/WICKET-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Martin Grigorov updated WICKET-6306:
> ------------------------------------
>      Fix Version/s:     (was: 8.0.0)
>
>> Changing model object of Panel added to a Border not allowed
>> ------------------------------------------------------------
>>
>>                  Key: WICKET-6306
>>                  URL: https://issues.apache.org/jira/browse/WICKET-6306
>>              Project: Wicket
>>           Issue Type: Bug
>>           Components: wicket
>>     Affects Versions: 7.5.0, 7.6.0
>>             Reporter: Dirk Forchel
>>             Assignee: Andrea Del Bene
>>              Fix For: 7.7.0, 8.0.0-M4
>>
>>          Attachments: testproject.zip
>>
>>
>> It is not allowed to change the model object of a panel added to a border component (see attachment).
>> The quickstart demonstrates the problem. Here you can find 3 test pages all with a TextField and a Panel with a TextField. For each component, the model object is set at the onConfigure method. At the first page both components are added to the page itself. At the second page both components are added to the border body container of a Border component. At the third page both components are added to a "Layout" container (a Border component too). The third page is not rendered with Wicket 7.5.0 (see stacktrace).
>> It was working for Wicket 7.4.0
>> org.apache.wicket.WicketRuntimeException: Cannot modify component hierarchy after render phase has started (page version cant change then anymore)
>>       at org.apache.wicket.Component.checkHierarchyChange(Component.java:3674)
>>       at org.apache.wicket.Page.dirty(Page.java:271)
>>       at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:332)
>>       at org.apache.wicket.Page.dirty(Page.java:250)
>>       at org.apache.wicket.Page.componentModelChanging(Page.java:904)
>>       at org.apache.wicket.Component.modelChanging(Component.java:2230)
>>       at org.apache.wicket.Component.setDefaultModelObject(Component.java:3133)
>>       at org.apache.wicket.markup.html.form.FormComponent.setModelObject(FormComponent.java:1579)
>>       at com.mycompany.front.wicket.components.TestPanel.onConfigure(TestPanel.java:30)
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)


Re: [jira] [Updated] (WICKET-6306) Changing model object of Panel added to a Border not allowed

Posted by Martin Grigorov <mg...@apache.org>.
Hi Andrea,

I think the correct version should be 8.0.0-M4.
If you add 8.0.0 then this ticket will appear in both changelogs.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Tue, Jan 17, 2017 at 9:52 AM, Andrea Del Bene <an...@gmail.com>
wrote:

> Hi Martin,
>
> should I remove version '8.0.0' from 'Fix version'?
>
> Andrea.
>
>
>
> On 16/01/2017 22:03, Martin Grigorov (JIRA) wrote:
>
>>       [ https://issues.apache.org/jira/browse/WICKET-6306?page=com.
>> atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Martin Grigorov updated WICKET-6306:
>> ------------------------------------
>>      Fix Version/s:     (was: 8.0.0)
>>
>> Changing model object of Panel added to a Border not allowed
>>> ------------------------------------------------------------
>>>
>>>                  Key: WICKET-6306
>>>                  URL: https://issues.apache.org/jira/browse/WICKET-6306
>>>              Project: Wicket
>>>           Issue Type: Bug
>>>           Components: wicket
>>>     Affects Versions: 7.5.0, 7.6.0
>>>             Reporter: Dirk Forchel
>>>             Assignee: Andrea Del Bene
>>>              Fix For: 7.7.0, 8.0.0-M4
>>>
>>>          Attachments: testproject.zip
>>>
>>>
>>> It is not allowed to change the model object of a panel added to a
>>> border component (see attachment).
>>> The quickstart demonstrates the problem. Here you can find 3 test pages
>>> all with a TextField and a Panel with a TextField. For each component, the
>>> model object is set at the onConfigure method. At the first page both
>>> components are added to the page itself. At the second page both components
>>> are added to the border body container of a Border component. At the third
>>> page both components are added to a "Layout" container (a Border component
>>> too). The third page is not rendered with Wicket 7.5.0 (see stacktrace).
>>> It was working for Wicket 7.4.0
>>> org.apache.wicket.WicketRuntimeException: Cannot modify component
>>> hierarchy after render phase has started (page version cant change then
>>> anymore)
>>>       at org.apache.wicket.Component.checkHierarchyChange(Component.
>>> java:3674)
>>>       at org.apache.wicket.Page.dirty(Page.java:271)
>>>       at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:332)
>>>       at org.apache.wicket.Page.dirty(Page.java:250)
>>>       at org.apache.wicket.Page.componentModelChanging(Page.java:904)
>>>       at org.apache.wicket.Component.modelChanging(Component.java:2230)
>>>       at org.apache.wicket.Component.setDefaultModelObject(Component.
>>> java:3133)
>>>       at org.apache.wicket.markup.html.form.FormComponent.setModelObj
>>> ect(FormComponent.java:1579)
>>>       at com.mycompany.front.wicket.components.TestPanel.onConfigure(
>>> TestPanel.java:30)
>>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>>
>
>