[GitHub] [airflow] dstandish commented on a diff in pull request #31757: feat(jobs/triggerer_job_runner): add triggerer canceled log

["dstandish (via GitHub)" <gi...@apache.org>]

dstandish commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1228503159


##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -608,6 +609,14 @@ async def run_trigger(self, trigger_id, trigger):
                 self.log.info("Trigger %s fired: %s", self.triggers[trigger_id]["name"], event)
                 self.triggers[trigger_id]["events"] += 1
                 self.events.append((trigger_id, event))
+
+            trigger_timeout = trigger.task_instance.trigger_timeout
+            if trigger_timeout and trigger_timeout < timezone.utcnow():
+                self.log.info("Trigger cancelled due to timeout")
+                raise asyncio.CancelledError("Trigger cancelled due to timeout")

Review Comment:
   i think this needs to be moved inside the `except asyncio.CancelledError as err` block



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org