You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gaborgsomogyi <gi...@git.apache.org> on 2018/01/02 09:54:35 UTC

[GitHub] spark pull request #20019: [SPARK-22361][SQL][TEST] Add unit test for Window...

Github user gaborgsomogyi commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20019#discussion_r159196803
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala ---
    @@ -263,21 +263,60 @@ class ExpressionParserSuite extends PlanTest {
           "sum(product + 1) over (partition by ((product / 2) + 1) order by 2)",
           WindowExpression('sum.function('product + 1),
             WindowSpecDefinition(Seq('product / 2 + 1), Seq(Literal(2).asc), UnspecifiedFrame)))
    +  }
    +
    +  test("range/rows window function expressions") {
    --- End diff --
    
    Just back from holiday. What do you mean exactly here? Range/rows between test with most of the combinations. What is missing?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org