You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/08/14 03:03:17 UTC
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1145: [#825][part-4] feat(spark): Report write failures to ShuffleManager
codecov-commenter commented on PR #1145:
URL: https://github.com/apache/incubator-uniffle/pull/1145#issuecomment-1676602629
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1145](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (237bef5) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/1406e1fceeeedd87820033513da941964dbdbd74?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1406e1f) will **decrease** coverage by `0.35%`.
> Report is 3 commits behind head on master.
> The diff coverage is `8.96%`.
```diff
@@ Coverage Diff @@
## master #1145 +/- ##
============================================
- Coverage 53.70% 53.36% -0.35%
+ Complexity 2573 2107 -466
============================================
Files 391 322 -69
Lines 22314 14653 -7661
Branches 1867 1328 -539
============================================
- Hits 11984 7819 -4165
+ Misses 9622 6410 -3212
+ Partials 708 424 -284
```
| [Files Changed](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/uniffle/common/ShuffleServerInfo.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NvbW1vbi9TaHVmZmxlU2VydmVySW5mby5qYXZh) | `63.82% <0.00%> (-32.95%)` | :arrow_down: |
| [...he/uniffle/coordinator/CoordinatorGrpcService.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvQ29vcmRpbmF0b3JHcnBjU2VydmljZS5qYXZh) | `1.62% <0.00%> (-0.28%)` | :arrow_down: |
| [...assignment/PartitionBalanceAssignmentStrategy.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivc3RyYXRlZ3kvYXNzaWdubWVudC9QYXJ0aXRpb25CYWxhbmNlQXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `56.52% <0.00%> (-39.07%)` | :arrow_down: |
| [...niffle/client/impl/grpc/CoordinatorGrpcClient.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL2dycGMvQ29vcmRpbmF0b3JHcnBjQ2xpZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...fle/client/impl/grpc/ShuffleManagerGrpcClient.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9pbXBsL2dycGMvU2h1ZmZsZU1hbmFnZXJHcnBjQ2xpZW50LmphdmE=) | `38.46% <0.00%> (-11.54%)` | :arrow_down: |
| [...ent/request/RssGetReShuffleAssignmentsRequest.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9yZXF1ZXN0L1Jzc0dldFJlU2h1ZmZsZUFzc2lnbm1lbnRzUmVxdWVzdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...nt/request/RssPartitionToShuffleServerRequest.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9yZXF1ZXN0L1Jzc1BhcnRpdGlvblRvU2h1ZmZsZVNlcnZlclJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../response/RssPartitionToShuffleServerResponse.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL2NsaWVudC9yZXNwb25zZS9Sc3NQYXJ0aXRpb25Ub1NodWZmbGVTZXJ2ZXJSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...r/strategy/assignment/BasicAssignmentStrategy.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3Ivc3RyYXRlZ3kvYXNzaWdubWVudC9CYXNpY0Fzc2lnbm1lbnRTdHJhdGVneS5qYXZh) | `62.50% <15.38%> (-32.74%)` | :arrow_down: |
| [...ache/uniffle/coordinator/SimpleClusterManager.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29vcmRpbmF0b3Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3VuaWZmbGUvY29vcmRpbmF0b3IvU2ltcGxlQ2x1c3Rlck1hbmFnZXIuamF2YQ==) | `74.22% <37.50%> (-3.31%)` | :arrow_down: |
| ... and [2 more](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [73 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org