[GitHub] [pinot] ankitsultana commented on pull request #8188: Add Support for Getting Live Brokers for a Table (without type suffix)

[GitBox <gi...@apache.org>]

ankitsultana commented on pull request #8188:
URL: https://github.com/apache/pinot/pull/8188#issuecomment-1035345631


   @mcvsubbu : Our main use case is to get live brokers of a table. For upstream callers like say Presto, users and the caller aren't aware of the different table-types associated with a given table, and hence the only way to get live brokers for a table in that case would be to try the current API with both table types. Lmk if there's another way to do this.
   
   I looked around and it seems this is the only `/tables` API which uses `tableNameWithType`, all the other APIs use `tableName`, so I think moving to this API would make things more consistent.
   
   I agree adding APIs isn't tenable and prone to adding more tech debt, but I think in this case this is also cleaning up older tech debt (this was also a comment on the original PR: https://github.com/apache/pinot/commit/e2e3aebab2712accc15190d6d3984b7c9e6de5d7#r738959901).
   
   I think there are a couple other options worth considering:
   
   1. Making this change within the existing API. This would change the behavior of the API only if the passed table name doesn't contain table type. Still, this is a change in behavior so not exactly backwards compatible.
   2. Deprecate the previous `/tables/{tableNameWithType}/livebrokers` API and keep this one. This will make the APIs consistent in that they all take in a table name either with or without type.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org