You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/29 16:03:19 UTC
[GitHub] [dubbo] plusmancn opened a new pull request #8963: [ISSUE 8961] Replace RpcContext.getServiceContext in InstanceAddressURL with private instance filed.
plusmancn opened a new pull request #8963:
URL: https://github.com/apache/dubbo/pull/8963
## What is the purpose of the change
Fixes #8961
## Brief changelog
## Verifying this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #8963: [ISSUE 8961] Replace RpcContext.getServiceContext in InstanceAddressURL with private instance filed.
Posted by GitBox <gi...@apache.org>.
AlbumenJ commented on pull request #8963:
URL: https://github.com/apache/dubbo/pull/8963#issuecomment-930698545
InstanceAddressURL is shared for many threads which can reduce object allocation for each service. So, InstanceAddressURL with different thread (or RpcServiceContext) can get difference parameters. You can think that InstanceAddressURL is aggregated with a lot of services in the same app, and we can get each service's parameter with current thread's state(RpcServiceContext).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn closed pull request #8963: [ISSUE 8961] Replace RpcContext.getServiceContext in InstanceAddressURL with private instance filed.
Posted by GitBox <gi...@apache.org>.
plusmancn closed pull request #8963:
URL: https://github.com/apache/dubbo/pull/8963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] plusmancn commented on pull request #8963: [ISSUE 8961] Replace RpcContext.getServiceContext in InstanceAddressURL with private instance filed.
Posted by GitBox <gi...@apache.org>.
plusmancn commented on pull request #8963:
URL: https://github.com/apache/dubbo/pull/8963#issuecomment-930701313
@AlbumenJ Thanks, according to your suggestions, If I want to fix the NPE problem, I should have a try to set RpcServiceContext in the thread which has a null value of RpcServiceContext, is that right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org