[GitHub] [arrow-datafusion] andygrove commented on a change in pull request #394: #352: BallistaContext::collect() logging is too noisy

[GitBox <gi...@apache.org>]

andygrove commented on a change in pull request #394:
URL: https://github.com/apache/arrow-datafusion/pull/394#discussion_r640115121



##########
File path: ballista/rust/client/src/context.rs
##########
@@ -198,14 +200,21 @@ impl BallistaContext {
                 DataFusionError::Internal("Received empty status message".to_owned())
             })?;
             let wait_future = tokio::time::sleep(Duration::from_millis(100));
+            let has_status_change = prev_status.map(|x| x != status).unwrap_or(false);

Review comment:
       ```suggestion
               let has_status_change = prev_status.map(|x| x != status).unwrap_or(true);
   ```
   I think the default should be `true` here. If there was no previous status then the status must have changed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org