You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 03:09:45 UTC

[GitHub] [spark] xuanyuanking commented on pull request #30344: [SPARK-30294][SS][FOLLOW-UP] Directly override RDD methods

xuanyuanking commented on pull request #30344:
URL: https://github.com/apache/spark/pull/30344#issuecomment-725800383


   Thanks for the quick response @HyukjinKwon @HeartSaVioR 
   Yes, I volunteer to take some time investigating the Mima error as I mentioned in the comment. The `DirectAbstractMethodProblem` happens when the old method is concrete but the new one is deferred. 
   https://github.com/lightbend/mima/blob/f25269a43ca3c19d0b587f61d33655eeddb888aa/core/src/main/scala/com/typesafe/tools/mima/lib/analyze/method/MethodChecker.scala#L56-L57
   So it should be a Mima friendly fix then.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org