You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/06/11 04:08:32 UTC
[GitHub] [skywalking] xiaomiusa87 opened a new issue, #9201: [Bug] FileWriter may produce one NPE per second
xiaomiusa87 opened a new issue, #9201:
URL: https://github.com/apache/skywalking/issues/9201
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
Java Agent (apache/skywalking-java)
### What happened
When Config.Logging.MAX_FILE_SIZE is smaller，fileOutputStream will be set to null.
But LogFileWriter scheduled tasks are still executing ，fileOutputStream.flush() will produce NPE ，Although it was captured
### What you expected to happen
Expect not produce NPE
### How to reproduce
Skywalking version: 8.9.1
Skywalking-Java-Agent version: 8.10.0
SpringBoot
### Anything else
No response
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9201: [Bug] FileWriter may produce one NPE per second
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9201:
URL: https://github.com/apache/skywalking/issues/9201#issuecomment-1152872934
The fix is good. I want to be clear, this bug is caused by `fileOutputStream` has been flushed and cleared when switching to a new file. So this bug doesn't relate to time(per second), more about reach the limit of file size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xiaomiusa87 commented on issue #9201: [Bug] fileOutputStream in FileWriter has been flushed and cleared when switching to a new file, which causes NPE.
Posted by GitBox <gi...@apache.org>.
xiaomiusa87 commented on issue #9201:
URL: https://github.com/apache/skywalking/issues/9201#issuecomment-1152873808
> The fix is good. I want to be clear, this bug is caused by `fileOutputStream` has been flushed and cleared when switching to a new file. So this bug doesn't relate to time(per second), more about reach the limit of file size.
Yes, it has little effect. It just seems a little strange
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9201: [Bug] fileOutputStream in FileWriter has been flushed and cleared when switching to a new file, which causes NPE.
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9201: [Bug] fileOutputStream in FileWriter has been flushed and cleared when switching to a new file, which causes NPE.
URL: https://github.com/apache/skywalking/issues/9201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9201: [Bug] FileWriter may produce one NPE per second
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9201:
URL: https://github.com/apache/skywalking/issues/9201#issuecomment-1152851891
Wait for your pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xiaomiusa87 commented on issue #9201: [Bug] FileWriter may produce one NPE per second
Posted by GitBox <gi...@apache.org>.
xiaomiusa87 commented on issue #9201:
URL: https://github.com/apache/skywalking/issues/9201#issuecomment-1152870755
> Wait for your pull request.
I have submitted pr : https://github.com/apache/skywalking-java/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org