You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/09 09:12:00 UTC

[GitHub] [shardingsphere] zjcnb commented on a diff in pull request #18237: properties spring.shardingsphere.enable docs supplement

zjcnb commented on code in PR #18237:
URL: https://github.com/apache/shardingsphere/pull/18237#discussion_r893265798


##########
docs/document/content/user-manual/shardingsphere-jdbc/spring-boot-starter/data-source.en.md:
##########
@@ -9,6 +9,7 @@ chapter = true
 ### Configuration Item Explanation
 
 ```properties
+spring.shardingsphere.enabled= # Whether enable shardingsphere or not, default value: true

Review Comment:
   I think should be remove this about this configuration :
   
   ```
       {
         "name": "spring.shardingsphere.enabled",
         "type": "java.lang.Boolean",
         "description": "Whether enable shardingsphere or not.",
         "defaultValue": true
       }
   ```
   
   It 's from additional-spring-configuration-metadata.json in `shardingsphere-jdbc-core-spring-boot-starter` module.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org