You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jay Kreps <bo...@gmail.com> on 2014/02/12 01:38:33 UTC
Review Request 17973: Producer should block until all requests are fully
acknowleged
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17973/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1259
https://issues.apache.org/jira/browse/KAFKA-1259
Repository: kafka
Description
-------
The producer was blocking until requests were sent but not waiting on the response when shutting down. Not how the test ever passed (it is a racy test so probably just good/bad luck) as this has been broken forever. The fix is to wait until all requests are completed.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
Diff: https://reviews.apache.org/r/17973/diff/
Testing
-------
Thanks,
Jay Kreps
Re: Review Request 17973: Producer should block until all requests are fully
acknowleged
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17973/#review34247
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On Feb. 12, 2014, 12:38 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17973/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 12:38 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1259
> https://issues.apache.org/jira/browse/KAFKA-1259
>
>
> Repository: kafka
>
>
> Description
> -------
>
> The producer was blocking until requests were sent but not waiting on the response when shutting down. Not how the test ever passed (it is a racy test so probably just good/bad luck) as this has been broken forever. The fix is to wait until all requests are completed.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
>
> Diff: https://reviews.apache.org/r/17973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>
Re: Review Request 17973: Producer should block until all requests are fully
acknowleged
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17973/#review34253
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Feb. 12, 2014, 12:38 a.m., Jay Kreps wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17973/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2014, 12:38 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1259
> https://issues.apache.org/jira/browse/KAFKA-1259
>
>
> Repository: kafka
>
>
> Description
> -------
>
> The producer was blocking until requests were sent but not waiting on the response when shutting down. Not how the test ever passed (it is a racy test so probably just good/bad luck) as this has been broken forever. The fix is to wait until all requests are completed.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java e8c194c8cdee570f7e3f5a48efa32f5f5c0bc9a4
>
> Diff: https://reviews.apache.org/r/17973/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Kreps
>
>