[GitHub] [pulsar-helm-chart] rdhabalia commented on a diff in pull request #269: Support mechanism to provide external zookeeper-server list to build global/configuration zookeeper

[GitBox <gi...@apache.org>]

rdhabalia commented on code in PR #269:
URL: https://github.com/apache/pulsar-helm-chart/pull/269#discussion_r907003823


##########
charts/pulsar/templates/zookeeper-statefulset.yaml:
##########
@@ -134,10 +134,19 @@ spec:
           containerPort: {{ .Values.zookeeper.ports.clientTls }}
         {{- end }}
         env:
-        - name: ZOOKEEPER_SERVERS
-          value:
-            {{- $global := . }}
-            {{ range $i, $e := until (.Values.zookeeper.replicaCount | int) }}{{ if ne $i 0 }},{{ end }}{{ template "pulsar.fullname" $global }}-{{ $global.Values.zookeeper.component }}-{{ printf "%d" $i }}{{ end }}
+         - name: ZOOKEEPER_SERVERS
+        {{- if .Values.zookeeper.configData.ZOOKEEPER_SERVERS }}

Review Comment:
   yes, I have added sample-example values in `examples/values-zookeeper-aws.yaml`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org